Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5703 - fixes loadable kbd files which were broken in recent changes

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Sunday, 23 July 2006, 14:49 GMT+2
Task Type Patches
Category Remote
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

when the vkeyboard was fixed for the remotes the user kbd files got broken.
I have hacked a fix together...
the keyboard now uses two files, .kbd for the main screen and .rkbd for the remote screen.
if the user only runs one of these files then the default keyboard will load for the other one. the users keyboard will be loaded at startup if it is set.
and the 2 screens do not have to have the same keyboard layout... just dont look at the remote while using the main buttons :p
   loadable_keyboard.patch (11.4 KiB) 
 apps/filetree.c          |   12 ++++++-
 apps/keyboard.h          |    4 +-
 apps/settings.c          |   41 ++++++++++++++++++++-----
 apps/settings.h          |    3 +
 apps/tree.c              |    1 
 apps/tree.h              |    1 
 apps/recorder/keyboard.c |   76 ++++++++++++++++++++++-------------------------
 7 files changed, 86 insertions(+), 52 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Monday, 24 July 2006, 11:52 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  fixed!
Comment by Martin Scarratt (mmmm-) - Monday, 24 July 2006, 00:23 GMT+2
Nice work but I can't really see the point in having a separate kbd file for the remote.

Why would you want two different keyboards on two different screens? If you want more chars you can just put them in the main screen file...

Unless you can convince me.... ;)
Comment by Jonathan Gordon (jdgordon) - Monday, 24 July 2006, 02:49 GMT+2
because on the main screen you have heaps of room and can display everything, and on the remote sccreen its tiny and you cant. also because of the smaller screen, the layout wont look normal.

anyway, i did it becuase i have no idea how the changes for the remote screen to the kbd loader were supposed to work? it looked like it will read the main screen kbd then the remote, but you dont really know where one starts and the other finishes?
Comment by Jonathan Gordon (jdgordon) - Monday, 24 July 2006, 03:00 GMT+2
ok, i just noticed you commited a partial fix, will the layout be used on the remote? or will the default one be used? because it will most likely not look correct if the user one is being used.
Comment by Martin Scarratt (mmmm-) - Monday, 24 July 2006, 11:26 GMT+2
Partial???

works like a dream I'm telling you! :D

The same keyboard is loaded to both...It does look slightly different to the main screen but exactly the same chars appear (as you can page flip)
Comment by Jonathan Gordon (jdgordon) - Monday, 24 July 2006, 11:51 GMT+2
hehe, ok you win.. guess ill close this then

Loading...