Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5720 - improved meta data extraction from SID files

Attached to Project: Rockbox
Opened by Robert Kukla (roolku) - Wednesday, 26 July 2006, 02:33 GMT+2
Task Type Patches
Category ID3 / meta data
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

- strings are now converted to UTF-8 for proper display of umlauts and accented letters
- two more tags are extracted from the file:

* year goes into the year tag (obviously)
* copyright holder goes into the album tag (as most WPS will display that)
   sid_meta.patch (1.6 KiB) 
 metadata.c |   20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

This task depends upon

Closed by  Robert Kukla (roolku)
Wednesday, 28 February 2007, 01:59 GMT+2
Reason for closing:  Accepted
Comment by Robert Kukla (roolku) - Friday, 10 November 2006, 14:26 GMT+2
updated to current cvs
   sid_meta.patch (2.1 KiB) 
 metadata.c |   29 +++++++++++++++--------------
 1 file changed, 15 insertions(+), 14 deletions(-)

Comment by Daniel Stenberg (bagder) - Friday, 10 November 2006, 14:45 GMT+2
well, this patch now puts _back_ the blindly-assuming-input-data-is-correct that I just modified in CVS. I don't like that the metadata parser assumes that the metadata will be correct but it should survive invalid formats.
Comment by Robert Kukla (roolku) - Friday, 10 November 2006, 15:35 GMT+2
fair enough - how about this one?
   sid_meta.patch (1.6 KiB) 
 metadata.c |   21 +++++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

Loading...