Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5740 - X5 LCD Performance / Features Upgrade / Bug Fix

Attached to Project: Rockbox
Opened by Michael Sevakis (MikeS) - Sunday, 30 July 2006, 08:14 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type iAudio X5
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Speeds up the X5 LCD driver functions and implements all remaining APIs except lcd_blit and contains the bug fix found in  FS#5734 . The driver patch will be updated if the said bug fix is committed first.

The bootloader gets smaller versions of the lcd_update_* functions (less unrolling of loops).

x5-lcd-performance-before-and-after.txt show a table of framerates gathered using test_fps with the best of three runs for each data point. Should be self-explanatory.

x5-lcd-perf-and-features-test.patch.zip contains a test plugin to test the lcd functions that were changed/added. It exposes some APIs needed by the plugin. Remove the patch included in the zip before committing.
   x5-lcd-perf-and-features.patch.txt (24.8 KiB)
   x5-lcd-perf-and-features-test.patch.zip (2.6 KiB)
   x5-lcd-performance-before-and-after.txt (0.4 KiB)
This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Tuesday, 01 August 2006, 01:00 GMT+2
Reason for closing:  Fixed
Comment by Michael Sevakis (MikeS) - Sunday, 30 July 2006, 10:11 GMT+2
Here's an updated version. I removed the call to lcd_update in lcd_roll because I think it is a bad idea to force an update because the developer should decide when to update the display. Had to change the plugin as a result. All subsequent drawing operations are still transformed as they should be.

That's the only qualm I had so pick the way you like it better.
   x5-lcd-perf-and-features.patch.txt (25 KiB)
   x5-lcd-perf-and-features-test.patch.zip (2.6 KiB)
Comment by Rani Hod (RaeNye) - Monday, 31 July 2006, 21:39 GMT+2
please sync, #5734 was commited.

BTW, I previously tried Duff's device as well but I got no FPS gain since I had to take the code out of IRAM.
It's nice to see you got better results :)
Comment by Michael Sevakis (MikeS) - Monday, 31 July 2006, 23:51 GMT+2
Removing the lookup table gave me room to roam!

Here it is resynced with contrast change.
   x5-lcd-perf-and-features.patch.txt (19.2 KiB)

Loading...