Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5766 - Fix for various voice-related crashes

Attached to Project: Rockbox
Opened by Steve Bavin (pondlife) - Thursday, 03 August 2006, 18:05 GMT+2
Last edited by Steve Bavin (pondlife) - Tuesday, 15 August 2006, 19:09 GMT+2
Task Type Patches
Category Language
Status Closed
Assigned To No-one
Player Type All players
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The attached patch updates playback.c so that the required buffers for a voice codec are initialised even if no voice file is loaded, if thumbnail clips are in use. Without this, attempting to use .talk clips without a voice file will crash. See bug  FS#5570  for details.
This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Tuesday, 15 August 2006, 20:01 GMT+2
Reason for closing:  Accepted
Comment by Steve Bavin (pondlife) - Thursday, 03 August 2006, 18:12 GMT+2
Here's the patch.
   fixtalkwithoutvoice.patch (1.9 KiB) 
 apps/playback.c |   22 +++++++++-------------
 1 file changed, 9 insertions(+), 13 deletions(-)

Comment by Steve Bavin (pondlife) - Thursday, 03 August 2006, 19:49 GMT+2
OK, take 2. This will set up the voice codec if a voice file has been loaded or thumbnails are in use.
Comment by Steve Bavin (pondlife) - Thursday, 03 August 2006, 19:51 GMT+2
I keep forgetting to attach the right patch... here it is.
   take2.patch (3.1 KiB) 
 apps/playback.c |   19 ++++++++++++++-----
 apps/talk.h     |    1 +
 apps/talk.c     |   17 +++++++++++++----
 3 files changed, 28 insertions(+), 9 deletions(-)

Comment by Steve Bavin (pondlife) - Thursday, 03 August 2006, 20:07 GMT+2
Add the following patch to force a call to audio_set_crossfade when the .talk options are changed. This works a bit better, but still can crash. Unfortunately I don't have time to look further right now.
   settingsmod.patch (1.3 KiB) 
 apps/settings_menu.c |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comment by Steve Bavin (pondlife) - Tuesday, 15 August 2006, 19:12 GMT+2
Fixed the above problem and it seems to have been caused by the same bug which causes Ogg Vorbis (and maybe other codec) playback crashes. The attached patch supercedes all above attachments.
   fixvoicecrashes.patch (4.8 KiB) 
 apps/playback.c      |   23 ++++++++++++++++++-----
 apps/settings_menu.c |    8 +++++---
 apps/talk.h          |    1 +
 apps/talk.c          |   17 +++++++++++++----
 4 files changed, 37 insertions(+), 12 deletions(-)

Loading...