Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5795 - change the settings display and add groundwork for title in list widget

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Friday, 11 August 2006, 05:05 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch changes the settings display screen to use the list widget so you can see more than just the selected choice on the screen at once.
this change is only for the set_bool() and set_option() settings. I couldnt get the set_int() working correctly (and im not sure how well it would work in that screen anyway)

This also adds a title to the list (I have not added the title to the rest of the code, so dont worry about losing screen space in the menu/browser just yet...)

It compiles cleanly on h300 and player targets, but I havnt tested it on the player because SDL doesnt work atm, but it should work...
This task depends upon

Closed by  Dave Chapman (linuxstb)
Tuesday, 15 August 2006, 10:14 GMT+2
Reason for closing:  Accepted
Comment by Dan Everton (safetydan) - Friday, 11 August 2006, 13:53 GMT+2
I like this a lot. One problem though. Pressing LEFT on the H120 doesn't exit/cancel the menu anymore. I haven't got time to investigate this right now, but I'll take a look later if you don't beat me to it.
Comment by Dan Everton (safetydan) - Friday, 11 August 2006, 14:01 GMT+2
Oh, and it seems to work fine in the player simulator. No actual hardware to test with though.

Couple of more minor nits

1. The list label isn't centered at the top of the screen. I think you'll need to calculate the actual string width instead of just relying on the display->char_width value.
2. Some settings don't have titles. Check Sound Settings -> Crossfeed -> High-Frequency Attenuation. Notice the lack of title.
Comment by Jonathan Gordon (jdgordon) - Saturday, 12 August 2006, 10:44 GMT+2
hey,
pressing left will work once Linus commits the action stuff, i was too lazy to do the buttons properly.
and re the 2nd comments..
1) checking against the length is faster, which is why i did it this way, except on the char cell display->width is in cells not pixels(iirc) so that has to be changed
2. shows fine here, (h300)
Comment by Jonathan Gordon (jdgordon) - Saturday, 12 August 2006, 12:15 GMT+2
update:
- dont try to center the title on char cell display
- the int settings now use the list also
- apps/gui/select.[ch] is no longer needed, (i dont know how to tell patch to remove them)
Comment by Jonathan Gordon (jdgordon) - Saturday, 12 August 2006, 12:31 GMT+2
another really minor update... removed apps/gui/select[ch]
Comment by Jonathan Gordon (jdgordon) - Saturday, 12 August 2006, 13:47 GMT+2
oops... im a dill
Comment by Jonathan Gordon (jdgordon) - Saturday, 12 August 2006, 16:18 GMT+2
ok, it really compiles this time...
Comment by Jonathan Gordon (jdgordon) - Sunday, 13 August 2006, 07:26 GMT+2
the integer settings are now shown correctly (highest value is at the top.. not bottom)
Comment by Jonathan Gordon (jdgordon) - Sunday, 13 August 2006, 15:29 GMT+2
grr... my maths sux...
this one is ready to go..
(application/octet-stream)    settings.patch (25.8 KiB) 
 apps/SOURCES      |    1 
 apps/settings.c   |  203 +++++++++++++++++++++++++++++++-----------------------
 apps/gui/list.c   |   68 +++++++++++++++---
 apps/gui/list.h   |    8 +-
 apps/gui/select.c |  136 ------------------------------------
 apps/gui/select.h |  185 -------------------------------------------------
 6 files changed, 183 insertions(+), 418 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Tuesday, 15 August 2006, 09:48 GMT+2
minor fixes, all good now
(application/octet-stream)    settings.patch (16.8 KiB) 
 apps/SOURCES         |    1 
 apps/settings.c      |  212 ++++++++++++++++++++++++++++++---------------------
 apps/settings_menu.c |    7 +
 apps/gui/list.c      |   68 ++++++++++++++--
 apps/gui/list.h      |    8 +
 5 files changed, 197 insertions(+), 99 deletions(-)

Loading...