Rockbox

Tasklist

FS#5844 - Fix confused voice file memory allocation

Attached to Project: Rockbox
Opened by Steve Bavin (pondlife) - Friday, 18 August 2006, 08:59 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

My previous patch to make .talk clips work independently of voice files (put in CVS on 1st August 2006) introduced some confusion as to the allocation of memory for the voice file. Previous to that patch, the space required was set up in playback.c so that the voice file could be changed (e.g. when language changed) rather than being a one-off initialisation at boot time, which is what we have now.

I have since educated myself on the layout of memory under Rockbox and this patch restores the original, correct allocation strategy, whilst keeping a dedicated buffer for .talk clips.

Linus may be pleased to note I have tested that this compiles correctly on non-SWCODEC targets! (Although I don't have access to an Archos to actually test this on.)
This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Wednesday, 23 August 2006, 08:21 GMT
Reason for closing:  Accepted

Loading...