Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5845 - Make tagtree.c use buffer_alloc

Attached to Project: Rockbox
Opened by Steve Bavin (pondlife) - Friday, 18 August 2006, 11:03 GMT+2
Task Type Patches
Category Operating System/Drivers
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

tagtree.c contains a direct modification of audiobuf that can be replaced by a buffer_alloc call.
   tagtreeusebufferalloc.patch (0.8 KiB) 
 apps/tagtree.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Wednesday, 23 August 2006, 10:41 GMT+2
Reason for closing:  Accepted
Comment by Steve Bavin (pondlife) - Tuesday, 22 August 2006, 12:18 GMT+2
Now updated to use a single call to buffer_alloc - pre-passes tagnavi.config to count the number of lines in it. Would also fix memory corruption if audiobuf was used during the read process (highly unlikely scenario).
   tagtreealloc2.patch (2.1 KiB) 
 apps/tagtree.c |   57 ++++++++++++++++++++-------------------------------------
 1 file changed, 20 insertions(+), 37 deletions(-)

Loading...