Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5911 - Log playback queuing and tidy routine names

Attached to Project: Rockbox
Opened by Steve Bavin (pondlife) - Thursday, 31 August 2006, 11:39 GMT+2
Task Type Patches
Category Simulator
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch does two things to playback.c:
1) Adds logf calls to all enqueuing and dequeuing code; this is only enabled on the simulator by default, but you can easily enable it by #defining LOGF_QUEUES.
2) Adds suitable prefixes (audio_ or codec_) to routines that are only used on one particular thread and did not have a prefix before.
I found these changes invaluable when debugging playback.c and hopefully others will find they help too.
   playbackqueuelogging.patch (26.3 KiB) 
 apps/playback.c |  223 +++++++++++++++++++++++++++++++++++++++++---------------
 1 file changed, 164 insertions(+), 59 deletions(-)

This task depends upon

Closed by  Steve Bavin (pondlife)
Thursday, 31 August 2006, 12:05 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Added to CVS.

Loading...