Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5934 - bug #5529 patch

Attached to Project: Rockbox
Opened by Yoshihisa Uchida (Uchida) - Sunday, 03 September 2006, 21:20 GMT+2
Task Type Patches
Category Operating System/Drivers
Status Closed
Assigned To No-one
Player Type All players
Severity High
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Bug #5529 happnes the following reason.

If for some N (N = 0,1,2,3,...),
"tagcache_N.tcd"'s file size (byte) > 24 * commit_entry_count(i.e. commited song file count). (A)

then
 the function "tempbuf_locate" (defines tagcache.c) failed because the value of LOOKUP_BUF_DEPTH
(defines tagcache.c) was too small.

So that, it terminates abnormally while processing "Committing tagcache [N/13]".

This patch file is corrected to match the value of LOOKUP_BUF_DEPTH to the size of actual file tagcache_N.tcd (N = 0,1,2,...), and to set it, and condition (A) will not be approved and exists.
(application/octet-stream)    bug5529.patch (4.9 KiB)
 tagcache.c |   82 +++++++++++++++++++++++++++++++++++++++++++++++++++----------
 1 file changed, 69 insertions(+), 13 deletions(-)

This task depends upon

Closed by  Steve Bavin (pondlife)
Tuesday, 26 September 2006, 13:58 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Slasheri has committed a fix for this now, at least partly inspired by this patch.

Loading...