Rockbox

Tasklist

FS#5940 - Revised keymappings on the H10

Attached to Project: Rockbox
Opened by Nicolas Pennequin (nicolas_p) - Tuesday, 05 September 2006, 02:31 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To Barry Wardell (barrywardell)
Operating System iriver H10
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This is a new keymap for the H10. I tried to make it more consistent between the file browser and the WPS, but also with other rockbox targets (at least the H300).
There are some problems, this is more of a draft version than anything but i'm falling asleep so i'll improve it later.
I also cleaned the code up a little (removed some trailing spaces).
Please tell me what you think about it.

Basic ideas :
- Main menu : short press of the power button.
- Quickscreen : long press on <- ("Left" in the code but i rather see it as "Back")
- Context menu : long press on o ("Right" in the code but i rather see it as "OK")
- Stop is a long press of the Play button, even in the browser
- Pressing o/OK/Right from the WPS goes to the browser
- FF and RW ought to be PGUP and PGDN in the browser but i couldn't get them to work
- in the quickscreen and the pitchscreen, FF and RW replace "Left" and "Right" (the bitmaps represent FF and RW so it seems more logical/consistent)

I think that's all... I haven"t yet even looked at the plugins and some screens so i remind you again it's just a concept. I want your opinions :-)
This task depends upon

Closed by  Barry Wardell (barrywardell)
Sunday, 10 September 2006, 12:10 GMT
Reason for closing:  Fixed
Additional comments about closing:  The v3 patch was added to CVS with the addition of BUTTON_POWER|BUTTON_RIGHT for exiting debug screens.
Comment by Barry Wardell (barrywardell) - Tuesday, 05 September 2006, 13:23 GMT
I like this idea in general. Consistency is a good thing.

One thing I've noticed is that in the WPS you have to press right to go back to the Browser. I think it would make more sense to use Left for this.

Also, the quickscreen is a bit strange. I understand the reasoning behind using FF and REW, but given the positioning of the text on the screen, it's a bit counterintuitive.

It would be nice to be able to access pitch and id3 screens with just one button press if possible. Maybe one of them could be a short press on right if it was no longer to mean back to Browser?

One last thing which annoys me with the current keymaps too is that in the context menu, pressing back always brings you out of the context menu altogether, rather than just up a level.
Comment by Nicolas Pennequin (nicolas_p) - Tuesday, 05 September 2006, 13:51 GMT
"One thing I've noticed is that in the WPS you have to press right to go back to the Browser. I think it would make more sense to use Left for this."
You're right. My reasoning for choosing Right instead of Left was that going to the browser was a "browse" action rather than a "go back to browser" action, but it is a little counter-intuitive.

"Also, the quickscreen is a bit strange. I understand the reasoning behind using FF and REW, but given the positioning of the text on the screen, it's a bit counterintuitive."
I think it would be better to rearrange the layout of the quickscreen to make shuffle and repeat be displayed next to the FF and RW buttons. IMHO, suddenly making "<-" act as "left" is counter-intuitive. I was surprised by the behaviour of the quickscreen when i first tried rockbox on the H10 and it took me some time to understand how it worked.

"It would be nice to be able to access pitch and id3 screens with just one button press if possible. Maybe one of them could be a short press on right if it was no longer to mean back to Browser?"
I agree, but we should be careful not to make the pitch screen or ID3 screen more important than the context menu in the WPS. Maybe make a short press of right display the context menu and a long press display the ID3 screen.

"One last thing which annoys me with the current keymaps too is that in the context menu, pressing back always brings you out of the context menu altogether, rather than just up a level."
That's not a problem with the keymaps, actually, but one with rockbox in general.
Comment by Barry Wardell (barrywardell) - Tuesday, 05 September 2006, 20:26 GMT
Another couple of observations:

1. When you go into any of the debug screens, there is no way to exit. None of the keys work. We need a key mapping for this. I suggest back/left.
2. Long hold of Power is used for turning off, but the menu flashes up when you press Power too, so you always get the menu flashing up when turning off. requiring BUTTON_REL for the menu will probably fix that.
Comment by Barry Wardell (barrywardell) - Wednesday, 06 September 2006, 10:44 GMT
I updated the patch slightly. I changed it to be left to go to the Browser from the WPS. I also fixed the Power off show the menu bug.

The quickscreen still needs to be changes and I haven't found a solution for exiting the debug screens.

I was thinking again about the ID3 screen. Making it a long press and context a short press would break the consistency of the context menu between browser and wps screens. For that reason I've left short press of right doing nothing. Maybe there is a better solution?
Comment by Barry Wardell (barrywardell) - Wednesday, 06 September 2006, 13:38 GMT
Another problem. Screens with button_context_settings_r_is_inc (eq, time, colourpicker) trigger twice with Right and Left, once for the settings change, the second time for OK/Cancel.
Comment by Holger Winnemoeller (Lazerman) - Saturday, 09 September 2006, 17:33 GMT
So, this could already be in here somewhere, but I couldn't find it in feature requests..

how about changing the keymapping strategy altogether. Basically just define the number of available keys per target and possibly some special keys (like scroll wheels, which behave differently from normal keys) and then define default actions for menues (like back, forward, pgup, pgdown, ...). Then have a config file somewhere that provides a default mapping between actions and buttons (actions can define what kind of key they are supporting, like FF/REW supports both click button and scroll wheel, but a SELECT action might just support a click button). Then you also have a config menu end entry screen that let's users change any mapping they desire (for rockbox itself but also individually for each plugin).
This would:

- Follow the "all customizable" paradigm of rockbox
- Allow people to decide what's intuitive for themselves
- Make it easier to get better consistency (e.g. some plugins use different keymaps. If you change assignment in one place everything else has to be reprogrammed... instead of simply remapped via config
- Allow plugins (specifically games) to have a common way to map keys
- Get rid of much of the #ifdefs in plugins and possibly elsewhere, because the number of constants is reduced
- Make it much easier to include new hwardware targets. All you need is to define the number and type of keys available in one central location and write some nice config files

I haven't looked at the source code long enough to know how difficult this would be, but it seems it's doable and could be quite advantageous.
Just my 2c worth
Comment by Holger Winnemoeller (Lazerman) - Saturday, 09 September 2006, 17:39 GMT
Ok, just saw that there is already a action->key mapping mechanism (should've looked at the patch first :-). Points about using config files (instead of hardcoding) and having online access to change config still valid though, particularly for plugins, which sometimes seem awkward to control.
Comment by Barry Wardell (barrywardell) - Sunday, 10 September 2006, 10:55 GMT
The action mechanism is a very recent addition to Rockbox, and seems to be working well so far. I'm not too sure about the config files. Would it not be better to just decide on 1 good mapping and use that? Anyway, that's out of the scope of this bug.

So, here's the latest version. Just the problem of not being able to exit the debug screens remains.

Loading...