Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5972 - DivideByZero fix with recordings

Attached to Project: Rockbox
Opened by Toni (ahellmann) - Monday, 11 September 2006, 22:43 GMT+2
Task Type Patches
Category Recording
Status Closed
Assigned To No-one
Player Type All players
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch solves the DivideByZero problem (I05 at 0x31020634) at recording start/end on iriver. In read_peak_levels() were 2 uncontrolled divisions with variable values. This patch fixes http://www.rockbox.org/tracker/task/5961.
   recording.patch (1 KiB) 
 rockbox-daily-20060909/apps/recorder/recording.c |   15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

This task depends upon

Closed by  Martin Scarratt (mmmm-)
Wednesday, 13 September 2006, 20:22 GMT+2
Reason for closing:  Fixed
Comment by Magnus Holmgren (learman) - Tuesday, 12 September 2006, 19:31 GMT+2
Shouldn't something still be written to balance_mem?
Comment by Toni (ahellmann) - Tuesday, 12 September 2006, 22:47 GMT+2
At least for me the first priority is the stability of the player.
This I05-error was very annoying.
Secondly the zeros should be very rare at least in recording mode.
So to my understanding of the code there is no disadvantage with this patch.
But I am happy, if the AGC responsible programmer can solve the problem
in a more elaborated way.

Loading...