Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#5994 - Mark current font/wps when viewing all (resolution for FS#5080)

Attached to Project: Rockbox
Opened by Alexander Levin (fml2) - Thursday, 14 September 2006, 22:51 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Wednesday, 01 August 2007, 16:16 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Position cursor to the current setting when browsing fonts, wps, rwps, eq preset, fmr. This can't be done for themes since the current theme is not saved in the settings.
(application/octet-stream)    prepos-browsing.patch (5.2 KiB) 
 apps/eq_menu.c        |    2 +-
 apps/main_menu.c      |    4 ++--
 apps/settings_menu.c  |   16 ++++++++++------
 apps/tree.c           |   13 +++++++++++--
 apps/tree.h           |    3 ++-
 apps/recorder/radio.c |    3 ++-
 6 files changed, 28 insertions(+), 13 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Wednesday, 01 August 2007, 16:16 GMT+2
Reason for closing:  Rejected
Comment by Alexander Levin (fml2) - Friday, 15 September 2006, 22:20 GMT+2
Updated the patch:
- introduced constants for standard file extensions
- replaced strcpy+strcat with snprintf (it's safer) -- thanks Linus for the tip
- moved some constants into format string (they are not printed with %s anymore)

The one who will (hopefully) commit this patch: please adjust the definition of FONT_DIR, LANG_DIR, and CODECS_DIR in settings.h so that it contains ROCKBOX_DIR (like e.g. WPS_DIR). Places where these constants are used should be also adjusted.

Linus, my patch doesn't break the 'Follow playlist' feature -- testes with the sim and on target (iriver H1xx).
(application/octet-stream)    prepos-browsing.patch (9.8 KiB) 
 apps/eq_menu.c        |    2 +-
 apps/main_menu.c      |    4 ++--
 apps/settings.c       |   22 +++++++++++-----------
 apps/settings.h       |    8 ++++++++
 apps/settings_menu.c  |   16 ++++++++++------
 apps/tree.c           |   14 ++++++++++++--
 apps/tree.h           |    3 ++-
 apps/recorder/radio.c |    3 ++-
 8 files changed, 48 insertions(+), 24 deletions(-)

Comment by Rani Hod (RaeNye) - Monday, 25 September 2006, 18:29 GMT+2
I was thinking that maybe after jdgordon commits the new settings menu patch, it'd be better to have this done in a similar way (i.e., have a little arrow pointing to the current setting as well as beginning on it).

Loading...