Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6051 - Only voice the file tree when user stops scrolling

Attached to Project: Rockbox
Opened by Steve Bavin (pondlife) - Saturday, 23 September 2006, 18:17 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Currently, when a user has spelt or numbered file/directory voicing enabled, the voicing is queued immediately. This results in many voice clips being queued, (and is probably particularly noticable when using a scrollwheel).

This patch changes the spelt/numbered voicing to only trigger after the user hovers on a particular entry for 0.5s - the same mechanism which is already used for thumbnail clips (to avoid disk spin-ups).
(application/octet-stream)    delayvoicing.patch (8.9 KiB) 
 apps/tree.c     |  149 +++++++++++++++++++++++---------------------------------
 apps/filetree.h |    2 
 2 files changed, 64 insertions(+), 87 deletions(-)

This task depends upon

Closed by  Steve Bavin (pondlife)
Sunday, 08 October 2006, 11:45 GMT+2
Reason for closing:  Rejected
Additional comments about closing:  Probably not needed any more.
Comment by Jonas Häggqvist (rasher) - Saturday, 23 September 2006, 18:37 GMT+2
Strongly in favour of this (although I'll admit to rarely using the voice ui). It seems like the only sensible way to go about this, to me.
Comment by Stephane Doyon (sdoyon) - Saturday, 07 October 2006, 02:59 GMT+2
Don't know if I'm missing some background here as I'm new to Rockbox, but
would you explain what is the problem this is solving? As a blind user
(and programmer) I can tell you this sounds like a terrible idea to me. I
tried the .talk feature and I was completely put off by the 0.5s delay;
it makes navigating directories annoyingly unresponsive. Now for .talk
clips I can understand that it might chew up your battery pretty fast
since it spins and reads the disk all the time, but there's no such
problem with spelling is there?

If there really is a fundamental reason why this is absolutely necessary,
perhaps you might consider making the hover delay 0.1s?

For a blind user, there's no point trying to save on speech, we'll just
be waiting for it every time. If somehow sighted people would prefer a
delay, then you might make it a configurable setting?

Thanks
Comment by Stephane Doyon (sdoyon) - Saturday, 07 October 2006, 03:02 GMT+2
My player (IAUDIO) has a joystick though, I suppose that makes a difference...?
Comment by Steve Bavin (pondlife) - Sunday, 08 October 2006, 11:44 GMT+2
This was really intended to help scrollwheel users, but I don't have a scrollwheel here so no idea if it's any use!
I think this is a bit moot now the voicing doesn't queue old data so much (at least when stopped), so I don't think this will be going into CVS - I'll close it.

Loading...