Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6052 - more responsive skip

Attached to Project: Rockbox
Opened by RealNameCanBeAskedFor (MHen) - Sunday, 24 September 2006, 07:47 GMT+2
Task Type Patches
Category Music playback
Status Closed
Assigned To No-one
Player Type Archos Player
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This path improved the responsiveness of the skip commands while the buffer is filled with data. In particular, it allows you to skip during the first seconds of a song playing.

This is achieved by simply removing all pending MPEG_NEED_DATA from the mpeg_queue when inserting a skip there. Thus preventing the skip to be delayed by the loading of no-more-needed data.
(application/octet-stream)    responsive_skip.diff (2.1 KiB) 
 firmware/kernel.c        |   13 +++++++++++++
 firmware/mpeg.c          |    2 ++
 firmware/export/kernel.h |    1 +
 3 files changed, 16 insertions(+)

This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Thursday, 19 October 2006, 13:43 GMT+2
Reason for closing:  Accepted
Comment by Linus Nielsen Feltzing (linusnielsen) - Monday, 25 September 2006, 13:35 GMT+2
Looks nice and simple. I think we could commit it right away.

I think I'd like the function to be called queue_remove_from_head().
Comment by RealNameCanBeAskedFor (MHen) - Monday, 25 September 2006, 22:40 GMT+2
I am very happy, you like this patch. I attach is the same patch with the function renamed.
(application/octet-stream)    responsive_skip_2.diff (2 KiB) 
 firmware/kernel.c        |   13 +++++++++++++
 firmware/mpeg.c          |    2 ++
 firmware/export/kernel.h |    1 +
 3 files changed, 16 insertions(+)

Comment by Ryan Sawhill (ryran) - Monday, 25 September 2006, 23:32 GMT+2
Sweet.
Comment by Linus Nielsen Feltzing (linusnielsen) - Thursday, 19 October 2006, 10:03 GMT+2
Oooops, looks like I forgot about this one. Can I have your real name for the credits?
Comment by RealNameCanBeAskedFor (MHen) - Thursday, 19 October 2006, 12:20 GMT+2
Yes, after a while I was a bit confused, what to do next.

Of course you can have my real name.
http://resized.file.sc/anon/db6w7EH5.png
Comment by Linus Nielsen Feltzing (linusnielsen) - Thursday, 19 October 2006, 12:22 GMT+2
You do realize that I will put your name in the CREDITS file?
Comment by RealNameCanBeAskedFor (MHen) - Thursday, 19 October 2006, 13:33 GMT+2
Yes, I know that. I read that even before I started programming Rockbox (at http://www.rockbox.org/docs/contributing.html) and it's fine with me.

To explain my attitue in a few sentences: It's okay that anyone who reads something I wrote knows my name. But I want to avoid that anyone knowing my name can easily get a list of all things I wrote. Not because I have anything to hide, but because I do not have any control about that data. Who knows what a future employer will find in 30 years time, when he searches the Internet for my name.

But I'm not fanatic about that. The only sensible format of a credits file is plain text. To have my name in there is okay with me.

Loading...