Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6082 - Switch order of playlist / sound settings in WPS Context

Attached to Project: Rockbox
Opened by Mike Miller (mikeage) - Thursday, 28 September 2006, 16:36 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Saturday, 04 August 2007, 16:42 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch will reverse the order of the playlist/playlsit catalog and sound settings menu items in the WPS Context Menu.

With this patch, to view the current playlist from the WPS, simply:

Hold select
Select
Select

Instead of

Hold select
Down
Select
Select.

See http://forums.rockbox.org/index.php?topic=6736.0

   wps_context_order.patch (0.9 KiB) 
 onplay.c |   16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Saturday, 04 August 2007, 16:42 GMT+2
Reason for closing:  Rejected
Comment by Reza (afruff23) - Thursday, 12 October 2006, 06:42 GMT+2
This is much needed. The "view current playlist" menu item is too nested in the menus.
Comment by Mike Miller (mikeage) - Thursday, 12 October 2006, 06:45 GMT+2
It's still nested, but since it's only one unique button away, I think it's easier.
Comment by Ryan Sawhill (ryran) - Wednesday, 18 October 2006, 11:15 GMT+2
thank you thank you thank you. I really appreciate this patch. :)

(so obviously there's my vote for a commit.)
Comment by Steve Bavin (pondlife) - Monday, 30 October 2006, 17:57 GMT+2
I vote for a commit too.
Comment by Jon (ace214) - Monday, 05 February 2007, 03:27 GMT+2
does this still actually work?
Comment by Mike Miller (mikeage) - Monday, 05 February 2007, 03:33 GMT+2
Of course it does :)

It'd be hard to _break_ a patch this simple and stupid...
Comment by Jon (ace214) - Monday, 05 February 2007, 03:34 GMT+2
when i applied it just now, it patched but didnt function on the device
Comment by Mike Miller (mikeage) - Monday, 05 February 2007, 03:56 GMT+2
Hrmm.

I just checked svn diff against the latest version.. the patch looks the same, although the line numbers changed. Perhaps since there's relatively little context, it's not applying it in the right place.

Try the attached.
   playlist_order.patch (0.8 KiB) 
 onplay.c |   16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

Comment by Jon (ace214) - Monday, 05 February 2007, 04:12 GMT+2
nope. didn't work.
Comment by Mike Miller (mikeage) - Monday, 05 February 2007, 04:19 GMT+2
Weird. Works for me on my ipod 4g gray... builds are available at mikeage.net/content/rockbox-custom-builds/

Do you see _any_ change at all?

When you press and hold select from the WPS, what menu items do you have?
Comment by Jon (ace214) - Monday, 05 February 2007, 04:30 GMT+2
OK, sorry. I was an idiot.... -_-
Comment by Mike Miller (mikeage) - Monday, 05 February 2007, 04:38 GMT+2
NP :)
Comment by Ryan Sawhill (ryran) - Monday, 05 February 2007, 04:46 GMT+2
nice. thanks for updating it Mike. :)
Comment by Ryan Sawhill (ryran) - Monday, 12 February 2007, 21:56 GMT+2
a simple synch
   playlist_order.patch (0.8 KiB) 
 onplay.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

Comment by Ryan Sawhill (ryran) - Monday, 02 April 2007, 22:02 GMT+2
sync to svn13005
   playlist-13005.patch (0.8 KiB) 
 onplay.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

Comment by Ryan Sawhill (ryran) - Monday, 30 April 2007, 22:03 GMT+2
ridiculously easy to do now with the new menu system... but sure.. why not.
   playlist-13295.patch (0.5 KiB) 
 onplay.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Loading...