Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6083 - Announcing tracks (DJ feature)

Attached to Project: Rockbox
Opened by Jonas Häggqvist (rasher) - Thursday, 28 September 2006, 16:40 GMT+2
Task Type Patches
Category Music playback
Status New
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

This patch was meant to add a DJ type feature, that would announce each song if a ".talk" clip exists for it. Unfortunately, it's not as simple as calling talk_file() each time the track changes, because that breaks playback because of CPU inadequacy. Works mostly fine for WAV files though.

The solution is probably to halt playback until the clip has been played, but that's beyond me.

I have not added a settings interface to this, since the feature is really very incomplete. I'd love if someone would pick it up from here though.
(application/octet-stream)    dj.patch (1.5 KiB) 
 playback.c |   24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

This task depends upon

Comment by Johannes Linke (Jaykay) - Tuesday, 16 December 2008, 21:21 GMT+2
i think this can be closed.....over 2 years old, doesnt apply, and i think nobody needs it. and according to rashers description its working only for .wav-files.
Comment by Jonas Häggqvist (rasher) - Tuesday, 16 December 2008, 23:34 GMT+2
I respectfully disagree. The code is mostly trivial - should be fairly easy to apply by hand and I think this feature would be reasonably useful for blind users. I still wish someone with some more playback-engine fu would pick this up and get it in shape for inclusion.

Of course, if everyone else is against it, it should be closed, but I don't think your reasons are enough to close it.

Loading...