Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6213 - Audioscrobbler incorrectly submits last song

Attached to Project: Rockbox
Opened by Reza (afruff23) - Friday, 20 October 2006, 07:07 GMT+1
Last edited by Peter D'Hoye (petur) - Sunday, 24 June 2007, 20:46 GMT+1
Task Type Bugs
Category Music playback
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This is very easy to reproduce. Listen to a song; do not go past the 50% point (listen for a few seconds or so). Now, while playing, turn off the player (in my case the iAudio X5). This also works even if you stop music playback then turn off(hold play/pause for a few seconds on the X5). When you submit the .log file, it counts this song as played even though you didn't go past the 50% point. I use LogScrobbler 0.8 to submit my songs BTW.
This task depends upon

Closed by  Peter D'Hoye (petur)
Sunday, 24 June 2007, 20:46 GMT+1
Reason for closing:  Accepted
Additional comments about closing:  Thank you ;)
Comment by Robert Keevil (obo) - Friday, 20 October 2006, 22:10 GMT+1
Because playback hasn't advanced to the next track, scrobbler.c is using the previous tracks elapsed value.

Attached patch fixes it for me on ipod (where direct shutdown isn't possible - since stop and shutdown share the same button). Does this work when the player is turned straight off?
(application/octet-stream)    scrobbler-shutdown.patch (1.2 KiB) 
 apps/playback.c |    2 ++
 firmware/mpeg.c |    5 +++++
 2 files changed, 7 insertions(+)

Comment by Robert Keevil (obo) - Monday, 30 October 2006, 22:38 GMT+1
This should fix the issue on devices with off buttons. Tested on ipod after enabling the Shutdown option in the main menu.

Can you test this attached patch?
(application/octet-stream)    scrobbler-shutdown.patch (4.2 KiB) 
 apps/misc.c      |    2 ++
 apps/playback.c  |    2 ++
 apps/scrobbler.c |   30 ++++++++++++++++++++++--------
 apps/scrobbler.h |    1 +
 firmware/mpeg.c  |    5 +++++
 5 files changed, 32 insertions(+), 8 deletions(-)

Comment by Linus Nielsen Feltzing (linusnielsen) - Monday, 22 January 2007, 14:27 GMT+1
Does anybody know if this patch solves the problem for all players? I want to commit it.
Comment by Robert Keevil (obo) - Sunday, 11 February 2007, 23:17 GMT+1
Re-sync'd and re-tested, on a 5g. I can't see why it would be different on any other SWCODEC target. Needs testing on a HWCODEC device, but last.fm logging is currently broken for Archos targets ( FS#6639 ).
   scrobbler-shutdown.patch (3.6 KiB) 
 apps/playback.c  |    2 ++
 apps/scrobbler.c |   30 ++++++++++++++++++++++--------
 apps/scrobbler.h |    1 +
 apps/misc.c      |    2 ++
 firmware/mpeg.c  |    5 +++++
 5 files changed, 32 insertions(+), 8 deletions(-)

Comment by Robert Keevil (obo) - Saturday, 05 May 2007, 12:06 GMT+1
Sync'd
   20070505-shutdown.patch (3.7 KiB) 
 apps/playback.c  |    2 ++
 apps/scrobbler.c |   30 ++++++++++++++++++++++--------
 apps/scrobbler.h |    1 +
 apps/misc.c      |    2 ++
 firmware/mpeg.c  |    5 +++++
 5 files changed, 32 insertions(+), 8 deletions(-)

Loading...