Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6266 - Flush buffered audio if user skips during pause

Attached to Project: Rockbox
Opened by Steve Bavin (pondlife) - Tuesday, 31 October 2006, 17:39 GMT+2
Last edited by Steve Bavin (pondlife) - Tuesday, 31 July 2007, 09:58 GMT+2
Task Type Patches
Category Music playback
Status Closed
Assigned To No-one
Player Type SW-codec
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

If the user skips to a new track while playback is paused, upon resuming a little bit of the previous track is played. This patch detects this scenario and flushes the old data before resuming playback.
(application/octet-stream)    flush_on_skip_during_pause.patch (1.7 KiB) 
 apps/playback.c |    8 ++++++++
 1 file changed, 8 insertions(+)

This task depends upon

Closed by  Steve Bavin (pondlife)
Tuesday, 31 July 2007, 09:58 GMT+2
Reason for closing:  Accepted
Comment by Steve Bavin (pondlife) - Wednesday, 01 November 2006, 09:05 GMT+2
Note this patch could be simplified quite a bit, but would break the sim until  FS#6267  is fixed. Hence the need for another global variable :(
Comment by Steve Bavin (pondlife) - Wednesday, 07 February 2007, 11:13 GMT+2
Sync to SVN
(application/octet-stream)    flush_on_skip_during_pause-070207.patch (1.7 KiB) 
 apps/playback.c |   13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

Comment by Steve Bavin (pondlife) - Monday, 30 July 2007, 13:30 GMT+2
Sync to SVN - please test and report back!
   flush_on_skip_during_pause-070730.patch (1.6 KiB) 
 apps/playback.c |   11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

Comment by Peter D'Hoye (petur) - Tuesday, 31 July 2007, 00:19 GMT+2
Just tested this on h300 and works as advertised...
feel free to commit ;)
Comment by Johnathon Mihalop (Soul-Slayer) - Tuesday, 31 July 2007, 04:22 GMT+2
Confirmed on Gigabeat and H10. I think it's commitable :p
Comment by Linus Nielsen Feltzing (linusnielsen) - Tuesday, 31 July 2007, 06:42 GMT+2
Question: what would be the effect if we always flushed when resuming?
Comment by Linus Nielsen Feltzing (linusnielsen) - Tuesday, 31 July 2007, 06:50 GMT+2
Hmmm, maybe I should have had a better look at the patch before asking. It would of course break the crossfading. I was thinking that we shouldn't need to detect this scenario as a special case.

Loading...