Rockbox

Tasklist

FS#6315 - More Fixes to the OS X Sim

Attached to Project: Rockbox
Opened by Tom Ross (midgey34) - Saturday, 11 November 2006, 10:31 GMT
Task Type Patches
Category Battery/Charging
Status Closed
Assigned To No-one
Operating System All players
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Currently, OS X can't build any hwcodec target without crashing. This addresses that and a bit more.

1) Change apps/Makefile to only attempt to create libcodec.a for swcodec
2) Remove #include <sys/param.h> from /uisimulator/common/io.c since it doesn't seem to be used (correct me if I'm wrong)
3) Suppress warnings about multiple declarations by adding a flag to LDFLAGS (warnings produced by Doom still persist)
** 3) isn't really a solution, it just provides nicer output :) **

Compiles and works fine for the ondio, h100, and h300 sims on Mac OS X.

Note: this patch does not address issues with rockboxui not being able to close gracefully
This task depends upon

Closed by  Barry Wardell (barrywardell)
Saturday, 11 November 2006, 23:39 GMT
Reason for closing:  Accepted
Additional comments about closing:  Improved version of part 1 committed. Part 2 not committed because it is not necessary to fix the problem, and I\'m not too sure of its effect. Part 3 not committed because it only avoids the problem, rather than fixing it.
Comment by Tom Ross (midgey34) - Saturday, 11 November 2006, 19:24 GMT
Here's a slightly different approach that creates a dummy file for OS X instead.

It is important to note, that while both of these patches allow the hwcodec sims to builds, I have not been successful in playing an mp3 in them. The file will act like it is playing, but no sound will be produced. I believe it is decoding since oscilloscope and vumeter both seem to work.

Loading...