Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6336 - Patch to let Sansa e200 normal to be built.

Attached to Project: Rockbox
Opened by Gnelik (Gnelik) - Wednesday, 15 November 2006, 19:45 GMT+2
Task Type Patches
Category Operating System/Drivers
Status Closed
Assigned To No-one
Player Type PortalPlayer-based
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Patch to let Sansa e200 normal firmware to be built.
   e200.patch (24.9 KiB) 
 apps/debug_menu.c                                         |    6 
 apps/tree.c                                               |    3 
 firmware/SOURCES                                          |    4 
 firmware/app.lds                                          |    2 
 firmware/system.c                                         |    5 
 firmware/timer.c                                          |    2 
 firmware/usb.c                                            |    3 
 firmware/target/arm/sandisk/sansa-e200/ata-e200.c         |  565 +++++++++++---
 firmware/target/arm/sandisk/sansa-e200/backlight-target.h |   26 
 firmware/target/arm/sandisk/sansa-e200/lcd-e200.c         |   20 
 firmware/target/arm/sandisk/sansa-e200/usb-target.h       |   25 
 11 files changed, 562 insertions(+), 99 deletions(-)

This task depends upon

Closed by  Steve Bavin (pondlife)
Wednesday, 22 November 2006, 11:24 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  \"This is now in CVS\"

I\'ll close it then!
Comment by Daniel Ankers (dan_a) - Wednesday, 15 November 2006, 23:06 GMT+2
Nice.
There are a couple of places where you have checked for all of the CONFIG_CPU==PP50XX. You can replace these with defined (CPU_PP). You seemed to have missed a few things out, though - it did not compile cleanly for me.

Based on your patch, I've made a new one. It compiles with one warning (from the ATA driver,) but does not boot.
(application/octet-stream)    e200_2.patch (33.8 KiB) 
 b/apps/debug_menu.c                                         |    4 
 b/apps/plugins/plugin.lds                                   |    4 
 b/firmware/SOURCES                                          |    6 
 b/firmware/app.lds                                          |    2 
 b/firmware/system.c                                         |    6 
 b/firmware/target/arm/sandisk/sansa-e200/ata-e200.c         |  614 ++++++++++--
 b/firmware/target/arm/sandisk/sansa-e200/ata-target.h       |   44 
 b/firmware/target/arm/sandisk/sansa-e200/backlight-e200.c   |   25 
 b/firmware/target/arm/sandisk/sansa-e200/backlight-target.h |   26 
 b/firmware/target/arm/sandisk/sansa-e200/lcd-e200.c         |   30 
 b/firmware/target/arm/sandisk/sansa-e200/power-e200.c       |   26 
 b/firmware/target/arm/sandisk/sansa-e200/usb-e200.c         |   36 
 b/firmware/target/arm/sandisk/sansa-e200/usb-target.h       |   26 
 b/firmware/timer.c                                          |    2 
 b/firmware/usb.c                                            |    3 
 15 files changed, 776 insertions(+), 78 deletions(-)

Comment by Daniel Ankers (dan_a) - Friday, 17 November 2006, 10:41 GMT+2
Oops - the patch was against an old CVS. Updated.
(application/octet-stream)    e200_2.patch (34.5 KiB) 
 b/apps/debug_menu.c                                         |    4 
 b/apps/plugins/plugin.lds                                   |    4 
 b/firmware/SOURCES                                          |    5 
 b/firmware/app.lds                                          |    2 
 b/firmware/system.c                                         |    6 
 b/firmware/target/arm/sandisk/sansa-e200/ata-e200.c         |  614 ++++++++++--
 b/firmware/target/arm/sandisk/sansa-e200/ata-target.h       |   44 
 b/firmware/target/arm/sandisk/sansa-e200/backlight-e200.c   |   25 
 b/firmware/target/arm/sandisk/sansa-e200/backlight-target.h |   26 
 b/firmware/target/arm/sandisk/sansa-e200/lcd-e200.c         |   30 
 b/firmware/target/arm/sandisk/sansa-e200/power-e200.c       |   26 
 b/firmware/target/arm/sandisk/sansa-e200/usb-e200.c         |   36 
 b/firmware/target/arm/sandisk/sansa-e200/usb-target.h       |   26 
 b/firmware/timer.c                                          |    2 
 b/firmware/usb.c                                            |    3 
 15 files changed, 776 insertions(+), 77 deletions(-)

Comment by Daniel Ankers (dan_a) - Saturday, 18 November 2006, 19:40 GMT+2
The MI4 code overwrites some of the generated binary. This new version does a bit better at booting, but still doesn't get as far as showing the Rockbox logo.
(application/octet-stream)    e200_3.patch (33.4 KiB) 
 b/apps/debug_menu.c                                         |    4 
 b/apps/plugins/plugin.lds                                   |    4 
 b/firmware/SOURCES                                          |    5 
 b/firmware/app.lds                                          |    2 
 b/firmware/system.c                                         |    6 
 b/firmware/target/arm/crt0-pp.S                             |    2 
 b/firmware/target/arm/sandisk/sansa-e200/ata-e200.c         |  614 ++++++++++--
 b/firmware/target/arm/sandisk/sansa-e200/ata-target.h       |   44 
 b/firmware/target/arm/sandisk/sansa-e200/backlight-e200.c   |   25 
 b/firmware/target/arm/sandisk/sansa-e200/backlight-target.h |   26 
 b/firmware/target/arm/sandisk/sansa-e200/lcd-e200.c         |   30 
 b/firmware/target/arm/sandisk/sansa-e200/power-e200.c       |   26 
 b/firmware/target/arm/sandisk/sansa-e200/usb-e200.c         |   36 
 b/firmware/target/arm/sandisk/sansa-e200/usb-target.h       |   26 
 b/firmware/timer.c                                          |    2 
 b/firmware/usb.c                                            |    3 
 16 files changed, 777 insertions(+), 78 deletions(-)

Comment by Daniel Ankers (dan_a) - Sunday, 19 November 2006, 19:30 GMT+2
A much cleaner version of the above.
This corrects the codec definition, and drops the (incomplete) NAND driver.
This version compiles without any warnings.
(application/octet-stream)    e200_4.patch (0 KiB) 
 0 files changed

Comment by Daniel Ankers (dan_a) - Sunday, 19 November 2006, 23:09 GMT+2
This corrects problems we have found with the LCD driver.
There is a problem with the interrupt vectors not being copied properly which causes the boot to fail. This patch does nothing to fix that.
(application/octet-stream)    e200_5.patch (24.7 KiB) 
 b/apps/debug_menu.c                                         |    4 
 b/apps/plugins/plugin.lds                                   |    4 
 b/firmware/SOURCES                                          |    5 
 b/firmware/app.lds                                          |    2 
 b/firmware/export/config-e200.h                             |    4 
 b/firmware/export/config.h                                  |    3 
 b/firmware/pcm_playback.c                                   |   14 +
 b/firmware/rolo.c                                           |    8 
 b/firmware/sound.c                                          |   26 ++-
 b/firmware/system.c                                         |    6 
 b/firmware/target/arm/crt0-pp.S                             |    2 
 b/firmware/target/arm/sandisk/sansa-e200/ata-e200.c         |  100 ------------
 b/firmware/target/arm/sandisk/sansa-e200/ata-target.h       |   44 +++++
 b/firmware/target/arm/sandisk/sansa-e200/backlight-e200.c   |   25 +++
 b/firmware/target/arm/sandisk/sansa-e200/backlight-target.h |   26 +++
 b/firmware/target/arm/sandisk/sansa-e200/lcd-e200.c         |   56 ++++++
 b/firmware/target/arm/sandisk/sansa-e200/power-e200.c       |   26 +++
 b/firmware/target/arm/sandisk/sansa-e200/usb-e200.c         |   36 ++++
 b/firmware/target/arm/sandisk/sansa-e200/usb-target.h       |   26 +++
 b/firmware/timer.c                                          |    9 -
 b/firmware/usb.c                                            |    3 
 b/tools/configure                                           |    2 
 22 files changed, 296 insertions(+), 135 deletions(-)

Comment by Daniel Ankers (dan_a) - Tuesday, 21 November 2006, 19:55 GMT+2
This fixes the problem. It also includes the NAND driver again (with write support this time.) It is known to be faulty on 6/8Gb Sansas - I would not suggest testing it on one of those models.
(application/octet-stream)    e200_6.patch (46.3 KiB) 
 b/apps/debug_menu.c                                         |    4 
 b/apps/playback.c                                           |    2 
 b/apps/plugins/plugin.lds                                   |    8 
 b/firmware/SOURCES                                          |    5 
 b/firmware/app.lds                                          |    2 
 b/firmware/export/config-e200.h                             |    4 
 b/firmware/export/config.h                                  |    3 
 b/firmware/export/kernel.h                                  |    2 
 b/firmware/export/timer.h                                   |    2 
 b/firmware/kernel.c                                         |    2 
 b/firmware/pcm_playback.c                                   |   14 
 b/firmware/rolo.c                                           |    8 
 b/firmware/sound.c                                          |   26 
 b/firmware/system.c                                         |    6 
 b/firmware/target/arm/crt0-pp.S                             |   10 
 b/firmware/target/arm/sandisk/sansa-e200/ata-e200.c         |  615 ++++++++++--
 b/firmware/target/arm/sandisk/sansa-e200/ata-target.h       |   44 
 b/firmware/target/arm/sandisk/sansa-e200/backlight-e200.c   |   25 
 b/firmware/target/arm/sandisk/sansa-e200/backlight-target.h |   26 
 b/firmware/target/arm/sandisk/sansa-e200/lcd-e200.c         |   58 +
 b/firmware/target/arm/sandisk/sansa-e200/power-e200.c       |   26 
 b/firmware/target/arm/sandisk/sansa-e200/usb-e200.c         |   36 
 b/firmware/target/arm/sandisk/sansa-e200/usb-target.h       |   26 
 b/firmware/timer.c                                          |   13 
 b/firmware/usb.c                                            |    3 
 b/tools/configure                                           |    2 
 26 files changed, 859 insertions(+), 113 deletions(-)

Comment by Daniel Ankers (dan_a) - Wednesday, 22 November 2006, 02:38 GMT+2
This is now in CVS

Loading...