Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface → Language
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by fml2 - 2006-11-27
Last edited by nls - 2007-08-05

FS#6387 - Get rid of SYSFONT_PITCH_xxx strings

I saw the discussion in IRC. As I’m the last person who touched the pitch screen code…

Also changed the intial pitch screen mode to be ‘semitone’ (it was ‘percent’ before)

(application/octet-stream)    dispose_sysfont_pitch.patch (6.2 KiB)
The task depends upon
ID Project Summary Priority Severity Assigned To Progress
6574 Rockbox  FS#6574 - Lang v2 cleanup  Very Low Low
100%
Closed by  nls
2007-08-05 19:23
Reason for closing:  Accepted
petur commented on 2006-12-01 08:25

Alexander, the reason I didn’t commit this one last night is because I’m not 100% convinced that duplicating strings to rename them is the way to go. As the issue isn’t very critical I think it may be better to do a major lang file cleanup. And maybe first get rid of all sysfont stuff everywhere. This means a bit of work in recording screen,…

fml2 commented on 2006-12-01 11:56

D’accord. This should be discussed with someone who’s more familiar with the lang file logic and can better estimate the implications.

BTW: some string IDs (e.g. PITCH) were present since long ago, I just introduced those missing.

Thank you very much Peter!

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing