Index: apps/lang/english.lang =================================================================== --- apps/lang/english.lang (revision 12071) +++ apps/lang/english.lang (working copy) @@ -3850,16 +3850,16 @@ id: LANG_POWEROFF - desc: disk poweroff flag + desc: DEPRECATED user: - *: "Disk Poweroff" + *: "" - *: "Disk Poweroff" + *: deprecated - *: "Disk Poweroff" + *: "" Index: apps/settings.c =================================================================== --- apps/settings.c (revision 12071) +++ apps/settings.c (working copy) @@ -100,7 +100,7 @@ #include "eq_menu.h" #endif -#define CONFIG_BLOCK_VERSION 59 +#define CONFIG_BLOCK_VERSION 60 #define CONFIG_BLOCK_SIZE 512 #define RTC_BLOCK_SIZE 44 @@ -416,9 +416,6 @@ #endif /* disk */ #ifndef HAVE_MMC -#ifdef HAVE_ATA_POWER_OFF - {1, S_O(disk_poweroff), false, "disk poweroff", off_on }, -#endif {8, S_O(disk_spindown), 5, "disk spindown", NULL }, #endif /* HAVE_MMC */ @@ -1192,9 +1189,6 @@ dac_line_in(global_settings.line_in); #endif mpeg_id3_options(global_settings.id3_v1_first); -#ifdef HAVE_ATA_POWER_OFF - ata_poweroff(global_settings.disk_poweroff); -#endif set_poweroff_timeout(global_settings.poweroff); Index: apps/settings.h =================================================================== --- apps/settings.h (revision 12071) +++ apps/settings.h (working copy) @@ -278,7 +278,6 @@ int ff_rewind_min_step; /* FF/Rewind minimum step size */ int ff_rewind_accel; /* FF/Rewind acceleration (in seconds per doubling) */ int disk_spindown; /* time until disk spindown, in seconds (0=off) */ - bool disk_poweroff; /* whether to cut disk power after spindown or not */ int buffer_margin; /* MP3 buffer watermark margin, in seconds */ int peak_meter_release; /* units per read out */ Index: apps/settings_menu.c =================================================================== --- apps/settings_menu.c (revision 12071) +++ apps/settings_menu.c (working copy) @@ -1104,14 +1104,6 @@ ata_spindown, 1, 3, 254, NULL ); } -#ifdef HAVE_ATA_POWER_OFF -static bool poweroff(void) -{ - bool rc = set_bool(str(LANG_POWEROFF), &global_settings.disk_poweroff); - ata_poweroff(global_settings.disk_poweroff); - return rc; -} -#endif /* HAVE_ATA_POWEROFF */ #endif /* !HAVE_MMC */ #if CONFIG_CODEC == MAS3507D @@ -2115,9 +2107,6 @@ static const struct menu_item items[] = { { ID2P(LANG_SPINDOWN), spindown }, -#ifdef HAVE_ATA_POWER_OFF - { ID2P(LANG_POWEROFF), poweroff }, -#endif #ifdef HAVE_DIRCACHE { ID2P(LANG_DIRCACHE_ENABLE), dircache }, #endif Index: firmware/export/ata.h =================================================================== --- firmware/export/ata.h (revision 12071) +++ firmware/export/ata.h (working copy) @@ -38,7 +38,6 @@ extern void ata_enable(bool on); extern void ata_spindown(int seconds); -extern void ata_poweroff(bool enable); extern void ata_sleep(void); extern void ata_sleepnow(void); extern bool ata_disk_is_active(void); Index: firmware/powermgmt.c =================================================================== --- firmware/powermgmt.c (revision 12071) +++ firmware/powermgmt.c (working copy) @@ -30,7 +30,6 @@ #include "ata.h" #include "power.h" #include "button.h" -#include "ata.h" #include "audio.h" #include "mp3_playback.h" #include "usb.h" @@ -638,9 +637,6 @@ remote_backlight_set_timeout(2); #endif ata_spindown(3); -#ifdef HAVE_ATA_POWER_OFF - ata_poweroff(true); -#endif low_battery = true; } else if (low_battery && (battery_percent > 11)) { backlight_set_timeout(10); Index: firmware/drivers/ata.c =================================================================== --- firmware/drivers/ata.c (revision 12071) +++ firmware/drivers/ata.c (working copy) @@ -63,6 +63,10 @@ #define READ_TIMEOUT 5*HZ +#ifdef HAVE_ATA_POWER_OFF +#define ATA_POWER_OFF_TIMEOUT 2*HZ +#endif + static struct mutex ata_mtx; int ata_device; /* device 0 (master) or 1 (slave) */ @@ -75,9 +79,6 @@ static bool sleeping = true; static bool poweroff = false; static long sleep_timeout = 5*HZ; -#ifdef HAVE_ATA_POWER_OFF -static int poweroff_timeout = 2*HZ; -#endif #ifdef HAVE_LBA48 static bool lba48 = false; /* set for 48 bit addressing */ #endif @@ -561,16 +562,6 @@ sleep_timeout = seconds * HZ; } -#ifdef HAVE_ATA_POWER_OFF -void ata_poweroff(bool enable) -{ - if (enable) - poweroff_timeout = 2*HZ; - else - poweroff_timeout = 0; -} -#endif - bool ata_disk_is_active(void) { return !sleeping; @@ -654,8 +645,8 @@ } } #ifdef HAVE_ATA_POWER_OFF - if ( !spinup && sleeping && poweroff_timeout && !poweroff && - TIME_AFTER( current_tick, last_sleep + poweroff_timeout )) + if ( !spinup && sleeping && !poweroff && + TIME_AFTER( current_tick, last_sleep + ATA_POWER_OFF_TIMEOUT )) { mutex_lock(&ata_mtx); ide_power_enable(false);