Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6505 - Slider progressbar

Attached to Project: Rockbox
Opened by Nicolas Pennequin (nicolas_p) - Thursday, 04 January 2007, 18:30 GMT+1
Last edited by Paul Louden (Llorean) - Wednesday, 16 January 2008, 15:16 GMT+1
Task Type Patches
Category WPS
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch adds the %S|filename.bmp| WPS tag to allow displaying a slider bitmap instead of the regular progressbar.
It works exactly like %P|filename.bmp| (bitmap progressbar), but instead of displaying just a part of the specified bitmap, it will display it entirely at the right place to show the progress.

http://forums.rockbox.org/index.php?topic=8006.0 was the inspiration for this quick patch.
   progressbar_slider.patch (6.1 KiB) 
 gwps-common.c |   46 ++++++++++++++++++++++++++++++++++++++--------
 gwps-common.h |    4 ++++
 gwps.c        |    2 +-
 gwps.h        |    7 ++++++-
 4 files changed, 49 insertions(+), 10 deletions(-)

This task depends upon

Closed by  Paul Louden (Llorean)
Wednesday, 16 January 2008, 15:16 GMT+1
Reason for closing:  Duplicate
Additional comments about closing:  %px should cover this functionality in a much more flexible way.
Comment by Nicolas Pennequin (nicolas_p) - Friday, 05 January 2007, 15:27 GMT+1
(forget this)
Comment by Norbert Preining (norbusan) - Friday, 05 January 2007, 18:14 GMT+1
Included in my build: http://www.misticriver.net/showthread.php?t=42675
Thanks Nicolas!
Comment by Eddy (bascule) - Sunday, 04 February 2007, 09:43 GMT+1
While listening to a 146MB, 64kbps, 32000hz, 5:19:00(roughly) file the slider progressbar disappeared at the 3:36:00 -- 3:37:00 mark. It would stay gone until the end of the file. When the next file played it would appear again.
Tried with another different file(almost exact same attributes as above) and same thing occured.

I have a Gigabeat F20, Jan 27th build. No other patches applied. Custom theme(my own), BMP heavy. If any other info is required just ask.

I'd appreciate it if someone else tried to recreate this bug as well to collaborate with my own account.

Thank you & special thanks to the developer of this patch, I really dig this patch

http://forums.rockbox.org/index.php?topic=8640.0
Comment by Flake (Flake) - Saturday, 10 February 2007, 00:21 GMT+1
does it work with old style progress bar also?
Comment by Nicolas Pennequin (nicolas_p) - Sunday, 11 February 2007, 22:41 GMT+1
Flake: No, it doesn't. That would be a different thing to implement in the code.
Comment by Nicolas Pennequin (nicolas_p) - Monday, 12 February 2007, 22:28 GMT+1
Here is another version that *should* solve the problem described above.
   progressbar_slider.patch (5.5 KiB) 
 gwps-common.c |   39 ++++++++++++++++++++++++++++++++++++---
 gwps-common.h |    4 ++++
 gwps.c        |    2 +-
 gwps.h        |    7 ++++++-
 4 files changed, 47 insertions(+), 5 deletions(-)

Comment by Nicolas Pennequin (nicolas_p) - Saturday, 17 February 2007, 18:55 GMT+1
Previous version didn't solve the problem. This one does.
   progressbar_slider.patch (4.8 KiB) 
 gwps-common.c |   40 +++++++++++++++++++++++++++++++++++++---
 gwps-common.h |    4 ++++
 gwps.c        |    2 +-
 gwps.h        |    7 ++++++-
 4 files changed, 48 insertions(+), 5 deletions(-)

Comment by Frank Grisafi (JobVanDam) - Tuesday, 06 March 2007, 21:42 GMT+1
Ah jeez.... Sorry Nic but I think I found a bug, maybe.
I have a Gigabeat F20, Build is March 4.

The Progress Bar goes slightly past the point where I defined it to stop.
I remember the old version didn't go this far cause I explictly remember making the point where it stops one pixel less cause that was the way I wanted it.
Comment by Frank Grisafi (JobVanDam) - Tuesday, 06 March 2007, 21:44 GMT+1
Forgot to add...
If you don't feel like fixing this I'll totally understand and still want to thank you for making this nifty patch.
Comment by Hepdog (007quick) - Wednesday, 04 April 2007, 21:55 GMT+1
Needs A sync
Comment by Max Weninger (maxwen) - Monday, 30 April 2007, 19:33 GMT+1
synced
   progressbar_slider_20070430.patch (5.7 KiB) 
 gwps-common.c |   32 +++++++++++++++++++++++++++++++-
 gwps.h        |    8 +++++++-
 wps_debug.c   |    4 ++++
 wps_parser.c  |   18 ++++++++++++++----
 4 files changed, 56 insertions(+), 6 deletions(-)

Comment by Max Weninger (maxwen) - Monday, 30 April 2007, 19:37 GMT+1
cleanup
   progressbar_slider_20070430.patch (5.7 KiB) 
 gwps-common.c |   31 ++++++++++++++++++++++++++++++-
 gwps.h        |    8 +++++++-
 wps_debug.c   |    4 ++++
 wps_parser.c  |   18 ++++++++++++++----
 4 files changed, 55 insertions(+), 6 deletions(-)

Comment by Frank Grisafi (JobVanDam) - Wednesday, 16 May 2007, 02:11 GMT+1
I just had to say a big fat thank you to Nic for making the patch and Max for syncing it. Now it's absolute perfection needs no correction.
Comment by Max Weninger (maxwen) - Friday, 22 June 2007, 15:46 GMT+1
synced
   progressbar_slider_20070622.patch (5.1 KiB) 
 gwps-common.c |   31 ++++++++++++++++++++++++++++++-
 gwps.h        |    7 +++++++
 wps_debug.c   |    4 ++++
 wps_parser.c  |   10 +++++++++-
 4 files changed, 50 insertions(+), 2 deletions(-)

Comment by Frank Grisafi (JobVanDam) - Friday, 16 November 2007, 13:56 GMT+1
Needs another sync please. Started failing on the 11th of November.
Also if you want to fix it there's a bug where if the time goes past 3:33:33 the graphic for the progressbar disappears. After about 5 hours it starts to appear on the left of the screen.
Comment by Eddy (bascule) - Friday, 16 November 2007, 21:04 GMT+1
To be honest, i think this task could be closed now, as the recent-ish change to the progressbar to allow conditionals (http://www.rockbox.org/tracker/task/7476) allows this same functionality.

Comments?
Comment by Frank Grisafi (JobVanDam) - Friday, 16 November 2007, 22:30 GMT+1
The song percentage tag does have it's strengths (ie. vertical progress, curved progress) but because you have to plot the path of the progress it will never be as smooth as this patch. Also if you did try to replicate this patch with the tag it's possible you may run out of letters to use for the conditional.

With this patch you simply state start from point A and stop at point B.

Loading...