Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6506 - Correct battery level display

Attached to Project: Rockbox
Opened by Tobias Heimann (Killaruna) - Friday, 05 January 2007, 01:16 GMT+2
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

In the current build, the highest level battery icon in the WPS is only displayed for a level of 100. This patch corrects the problem and assigns the highest level an interval as all others.
   correct_battary_level.patch (0.9 KiB) 
 apps/gui/gwps-common.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

This task depends upon

Closed by  Nicolas Pennequin (nicolas_p)
Friday, 13 April 2007, 17:17 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  The new WPS code does this.
Comment by Eddy (bascule) - Friday, 05 January 2007, 10:11 GMT+2
I made an assumption that it was the designed behaviour, as with the volume enum.

It makes sense to me for maximum volume (0db) to have it's own state, because it represents the line-level output on those targets such as the H1x0 that has a variable level output on the line-out jack.

i.e., I have my volume indicator set in my WPS as:
%?pv<mute|v.v. low|v. low|low|med|high|v. high|v.v. high|line>

For the battery, you could argue that you may want a 'Full' or 'Max' indicator for the 100% value.
Comment by Paul Louden (darkkone) - Sunday, 07 January 2007, 01:23 GMT+2
Especially in the case of charging, being able to see 100% on its own is handy.

For WPSes one could readily use the same image for the top two cases so that it appears full, thus mimicing something like this behaviour without a patch, and still allowing the original behaviour in the original case.

Loading...