This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#6512 - Make plugin Disktidy avoid opening too many dirs
Attached to Project:
Rockbox
Opened by Magnus Lindström (mlind) - Saturday, 06 January 2007, 22:03 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Sunday, 10 August 2008, 14:53 GMT+2
Opened by Magnus Lindström (mlind) - Saturday, 06 January 2007, 22:03 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Sunday, 10 August 2008, 14:53 GMT+2
|
DetailsThe patch makes plugin Disktidy avoid going too deep into nested subfolders.
Due to a recursive function there was a possibility that the plugin tried to open more directories than the maximum 8 allowed. The patch is only tried on an iRiver H120. The patch is still in my experimental version and stops and waits for keypress RIGHT if open directories exceed 5. This was to be able to see what happened. Also I added line wrapping of the displayed path. Haven't checked what else has to be done according to RockBox standards 
disktidy.nestedsubfolders.patch
(3 KiB)
./apps/plugins/disktidy.c | 47 ++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 41 insertions(+), 6 deletions(-) |
This task depends upon
Closed by Jonathan Gordon (jdgordon)
Sunday, 10 August 2008, 14:53 GMT+2
Reason for closing: Out of Date
Additional comments about closing: no longer needed
Sunday, 10 August 2008, 14:53 GMT+2
Reason for closing: Out of Date
Additional comments about closing: no longer needed
If it's going to continue, it should at least make it very, very clear to the user that the operation was not completed successfully.
Only stops to show what dir it skips - and tells user to push PLAY/SELECT to continue.
When Disktidy is done there first comes a splash that says how many items were deleted, and then another one that says how many dirs it skipped.
It seems like a better idea to put the latest patch there...