Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6514 - Disktidy - only open a single directory handle at a time.

Attached to Project: Rockbox
Opened by David Dent (the_winch) - Sunday, 07 January 2007, 14:35 GMT+1
Last edited by Jonathan Gordon (jdgordon) - Sunday, 10 August 2008, 14:46 GMT+1
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Keeps track of the position within a directory so the dir handle can be closed when recursing into sub dirs.
When the subdir has been processed the dir is reopened and the required number of items skipped.

This should fix  FS#6410 .
(application/octet-stream)    disktidy.patch (5.5 KiB) 
 apps/plugins/disktidy.c |   84 +++++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 72 insertions(+), 12 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Sunday, 10 August 2008, 14:46 GMT+1
Reason for closing:  Out of Date
Additional comments about closing:  no longer needed
Comment by David Dent (the_winch) - Sunday, 07 January 2007, 19:25 GMT+1
Also check the return value of tidy_remove_dir().
(application/octet-stream)    disktidy.patch (5.6 KiB) 
 apps/plugins/disktidy.c |   86 ++++++++++++++++++++++++++++++++++++++++--------
 1 file changed, 73 insertions(+), 13 deletions(-)

Comment by Magnus Lindström (mlind) - Sunday, 07 January 2007, 22:49 GMT+1
As it seems to me it only adds ability to clean one more level of nested folder.
If you have even deeper folders you get stack overflow.

But for me today that is enough.

Loading...