Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6528 - ARM optimised memcpy/memmove

Attached to Project: Rockbox
Opened by Daniel Ankers (dan_a) - Thursday, 11 January 2007, 23:19 GMT+2
Task Type Patches
Category Operating System/Drivers
Status Closed
Assigned To No-one
Player Type PortalPlayer-based
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch adds the ARM optimised memcpy and memmove functions from glibc. It is almost a verbatim copy, with just a couple of changes to make it compile under Rockbox.

It increases the core size by nearly 1k, but I saw the CPU boost when playing MP3s on my 3G iPod drop below 100% for the first time ever with this patch.
(application/octet-stream)    arm-asm-memcpy.diff (11.6 KiB) 
 b/firmware/SOURCES                  |    4 
 b/firmware/target/arm/memcpy-arm.S  |  232 ++++++++++++++++++++++++++++++++++
 b/firmware/target/arm/memmove-arm.S |  245 ++++++++++++++++++++++++++++++++++++
 3 files changed, 479 insertions(+), 2 deletions(-)

This task depends upon

Closed by  Nicolas Pennequin (nicolas_p)
Sunday, 14 January 2007, 03:02 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Daniel committed this to SVN.
Comment by David Hall (Soap) - Saturday, 13 January 2007, 20:09 GMT+2
I performed each test three times.
Build 1 = 2007-01-13 SVN checkout + 64MB buffer patch on my (iPod 5th gen):
53 seconds to fill audio buffer and 70% boost @7 minutes into playback.

Build 2 = 2007-01-13 SVN checkout + 64MB buffer patch + this patch (on my iPod 5th gen):
47 seconds to fill audio buffer and 58% boost @7 minutes into playback.

Loading...