Rockbox

Tasklist

FS#6555 - Volume limiter

Attached to Project: Rockbox
Opened by Will Robertson (aliask) - Sunday, 21 January 2007, 03:35 GMT
Last edited by Jonathan Gordon (jdgordon) - Sunday, 05 August 2007, 10:53 GMT
Task Type Patches
Category Settings
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

As per a request from a friend I've implemented a feature from the iPod original firmware, volume limiting.
You can set a maximum volume, and while in the WPS you can't increase the volume past that point, to avoid blowing up your ears.
The patch has only been tested in the sims, and it bumps the config block version so you'll need to save your settings.
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Sunday, 05 August 2007, 10:53 GMT
Reason for closing:  Out of Date
Additional comments about closing:  if someone wants to start this again, imo it shuold be added to setvol() in misc.c and not touch any firmware/ code
Comment by Hepdog (007quick) - Thursday, 15 March 2007, 17:32 GMT
This patch is out of sync with current svn. Please update it because it would be really usfull!
Comment by Will Robertson (aliask) - Saturday, 17 March 2007, 09:34 GMT
Your wish is my command.
Comment by Hepdog (007quick) - Saturday, 17 March 2007, 14:54 GMT
Just to tell you, it is still out of sync! it still works becasue it is just a hunk that changes the manual! lol, how did that get in there?
Comment by Will Robertson (aliask) - Sunday, 18 March 2007, 08:17 GMT
Ugh, that file is strange... It's been getting into my patches lately for some reason - svn update doesn't see any difference but svn diff obviously does.
Anyway here's the fixed patch.
Comment by Sacha (Angyman) - Sunday, 18 March 2007, 15:58 GMT
Very useful!!!! Safety First^^
Comment by Nikkhil (AceNik) - Monday, 16 April 2007, 14:40 GMT
sync'ed, can someone please add this already
Comment by Dominik Riebeling (bluebrother) - Monday, 16 April 2007, 17:21 GMT
The patch contains unnecessary (and unwanted) whitespace changes.
Comment by Nikkhil (AceNik) - Monday, 16 April 2007, 17:40 GMT
can anyone fix it , i have no clue what it means
Comment by Will Robertson (aliask) - Tuesday, 17 April 2007, 00:33 GMT
When you're making a patch you have to be careful not to include tabs. Rockbox source uses 4 spaces for indentation.
Here's the fixed patch.
Comment by Nikkhil (AceNik) - Friday, 04 May 2007, 14:16 GMT
Sync'ed
Comment by Nikkhil (AceNik) - Monday, 28 May 2007, 18:58 GMT
patch needs sync, sound.c & sound.h have bin changed
Comment by Mark (Xebozone) - Saturday, 30 June 2007, 10:20 GMT
Can someone please add this to the regular builds?

Loading...