Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6668 - mp3 vbr gapless is broken

Attached to Project: Rockbox
Opened by Akio Idehara (idak) - Saturday, 17 February 2007, 16:49 GMT+2
Task Type Bugs
Category Music playback
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

I updated svn revision-12323.
And mp3 vbr (LAME encoded) file couldn't play with gapless at ipod 5g.

I think SW_CODEC definition is the cause.
This task depends upon

Closed by  Nils Wallménius (nls)
Sunday, 18 February 2007, 09:22 GMT+2
Reason for closing:  Fixed
Comment by Dave Chapman (linuxstb) - Saturday, 17 February 2007, 17:21 GMT+2

Do your files play gaplessly in other audio players (e.g. foobar) ?
Did they play gaplessly in earlier version of Rockbox?
Do you have any unusual tags in the files, e.g. APE?
Are you playing the files continuously from beginning to end, or are you seeking in them?
Comment by Akio Idehara (idak) - Saturday, 17 February 2007, 17:27 GMT+2
I played the same file in earlier version of Rockbox svn rev-12322.
This version can play with gapless.
Comment by Dave Chapman (linuxstb) - Saturday, 17 February 2007, 18:05 GMT+2
Can you try some of the other recent daily builds for the 5g and see which (if any) was the last one to play your files gaplessly? You can download them from here:

http://www.rockbox.org/dl.cgi?bin=ipodvideo

Are you also able to upload to somewhere a pair of test files that played gaplessly in previous versions of Rockbox, but don't any more?
Comment by Akio Idehara (idak) - Saturday, 17 February 2007, 18:28 GMT+2
I try recent daily builds (r12343-070217) for the 5g.
But this version is not able to play gaplessly.

I attach a pair of test files.
This file can play gaplessly in foobar2k and rockbox rev-12322.
   001 WAVE00.mp3 (234.7 KiB)
   002 WAVE01.mp3 (234.8 KiB)
Comment by Akio Idehara (idak) - Saturday, 17 February 2007, 18:59 GMT+2
I made a patch that delete SWCODEC check.
I can play gaplessly with this patch.
   del-SWCODEC_check.patch (1.4 KiB) 
 firmware/id3.c     |    2 --
 firmware/mp3data.c |    4 ----
 2 files changed, 6 deletions(-)

Comment by Linus Nielsen Feltzing (linusnielsen) - Saturday, 17 February 2007, 21:51 GMT+2
I have committed a fix for this. Thanks for reporting and helping me see the bad spelling of CONFIG_CODEC. Please test the next build and tell me if it works.
Comment by Akio Idehara (idak) - Sunday, 18 February 2007, 05:02 GMT+2
It works fine :)

Loading...