Rockbox

Tasklist

FS#6674 - Make definitions of HAVE_XXX symbols more consistent

Attached to Project: Rockbox
Opened by Alexander Levin (fml2) - Monday, 19 February 2007, 19:51 GMT
Task Type Patches
Category Configuration
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

I've followed the discussion about the usage of #if and #ifdef on the IRC. It was noticed that some HAVE_XXX symbols are defined with values. Here is the patch that corrects this. Fortunately, HAVE_XXX were tested only with #ifdef so that only definitions (and not usage) had to be changed. I have not compiled this on all platforms, only on H1xx and Gigabeat.

There is another sort of constants: CONFIG_XXX. They are all defined with values and should be tested with #if CONFIG_XXX == YYY.

Only rockbox's 'own' code was considered, not the third party libs since they should stay easy to merge with their respective master code base.

And while I'm at it, here is the list of all HAVE_XXX symbols (could be placed on a wiki page). Couldn't/Shouldn't the HAVE_WMnnnn group be replaced with one CONFIG_XXX?

HAVE_ADJUSTABLE_CPU_FREQ
HAVE_AGC
HAVE_ALARM_MOD
HAVE_ATA_LED_CTRL
HAVE_ATA_POWER_OFF
HAVE_BACKLIGHT_BRIGHTNESS
HAVE_BACKLIGHT_PWM_FADING
HAVE_BACKLIGHT_SET_FADING
HAVE_DAC3550A
HAVE_DIRCACHE
HAVE_DISPLAY_FLIPPED
HAVE_EEPROM
HAVE_EEPROM_SETTINGS
HAVE_EXTENDED_MESSAGING_AND_NAME
HAVE_FAT16SUPPORT
HAVE_FLASHED_ROCKBOX
HAVE_FLASH_DISK
HAVE_FMADC
HAVE_FMRADIO_IN
HAVE_GDB_API
HAVE_HEADPHONE_DETECTION
HAVE_HOTSWAP
HAVE_I2C_LOW_FIRST
HAVE_LCD_BITMAP
HAVE_LCD_CHARCELLS
HAVE_LCD_COLOR
HAVE_LCD_CONTRAST
HAVE_LCD_ENABLE
HAVE_LCD_FLIP
HAVE_LCD_INVERT
HAVE_LCD_SLEEP
HAVE_MAS_SIBI_CONTROL
HAVE_MMC
HAVE_MPEG2_5_SAMPR
HAVE_MPEG2_SAMPR
HAVE_MULTIVOLUME
HAVE_ONDIO_ADC
HAVE_ONDIO_I2C
HAVE_PITCHSCREEN
HAVE_PORTRAIT_LCD
HAVE_POWEROFF_ON_PADR
HAVE_POWEROFF_ON_PB5
HAVE_POWEROFF_ON_PBDR
HAVE_POWEROFF_WHILE_CHARGING
HAVE_PP5024_CODEC
HAVE_PRIORITY_SCHEDULING
HAVE_QUICKSCREEN
HAVE_RECORDING
HAVE_REMOTE_LCD
HAVE_REMOTE_LCD_TICKING
HAVE_RTC_RAM
HAVE_SCHEDULER_BOOSTCTRL
HAVE_SPDIF_IN
HAVE_SPDIF_OUT
HAVE_SPDIF_POWER
HAVE_SW_POWEROFF
HAVE_TAGCACHE
HAVE_TC_RAMCACHE
HAVE_TLV320
HAVE_TUNER_PWR_CTRL
HAVE_UDA1380
HAVE_USB_POWER
HAVE_WHEEL_POSITION
HAVE_WM8721
HAVE_WM8731
HAVE_WM8751
HAVE_WM8758
HAVE_WM8975
This task depends upon

Closed by  Barry Wardell (barrywardell)
Tuesday, 20 February 2007, 14:55 GMT
Reason for closing:  Accepted
Additional comments about closing:  Committed to SVN, thanks.

Loading...