Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6678 - Improved h10 scrollpad

Attached to Project: Rockbox
Opened by David Search (Damium) - Tuesday, 20 February 2007, 04:19 GMT+2
Last edited by Daniel Stenberg (bagder) - Monday, 19 November 2007, 23:55 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type iriver H10
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This causes the following logic to be used on the (quite chaotic) h10 scrollpad.

Check to see if a scroll button was being pressed last time we looked.
Scroll the same direction if it is within extended bounds (0x150-0x3FF is UP, 0x0-0x250 is DOWN).
If a button was not being pressed start scrolling if we are within the limited bounds (0x250-0x3FF is UP, 0x0-0x150 is DOWN).

ADC Scrollpad hardware reading:
0x0 0x150 0x250 0x3FF
*------*------*------*
|<<<<<<|><><><|>>>>>>|
DOWN LAST UP

I have tested this on my h10 20g. The "scrollback" effect if you were not pressing on the very top or bottom of the scrollpad is much less frequent with this logic.
(application/octet-stream)    h10smoothscroll.diff (1.4 KiB) 
 firmware/target/arm/iriver/h10/button-h10.c |   29 ++++++++++++++++++++--------
 1 file changed, 21 insertions(+), 8 deletions(-)

This task depends upon

Closed by  Daniel Stenberg (bagder)
Monday, 19 November 2007, 23:55 GMT+2
Reason for closing:  Rejected
Additional comments about closing:  "Latest SVN code is much better at scrolling. Patch is not needed."
Comment by Hepdog (007quick) - Tuesday, 20 February 2007, 17:13 GMT+2
Seems good except that when I tried it on my h10 5g the paramiters seemed awsome for the down scroll but unfortunetly the up was not working at all! the screen would even go dark when touching the up scroll. Sorry for the bad news! unless this is not designed for the 5gb!
Comment by Barry Wardell (barrywardell) - Tuesday, 20 February 2007, 17:18 GMT+2
There was a small bug in that code. I've attached a working version. I'm not totally convinced that it's better than what we already have though.
   h10smoothscroll2.diff (1.6 KiB) 
 firmware/target/arm/iriver/h10/button-h10.c |   25 +++++++++++++++++++------
 1 file changed, 19 insertions(+), 6 deletions(-)

Comment by David Search (Damium) - Tuesday, 20 February 2007, 17:40 GMT+2
That's what I get for making last moment changes before posting a patch...
Comment by Hepdog (007quick) - Wednesday, 09 May 2007, 22:40 GMT+2
Here is a different version which I think works better. Some of the code is an attempt to mimic the original firmware, so just bear with me. But I think that it all helps. Give it a try!
   scroll_pad_improvement.diff (4.8 KiB) 
 button-h10.c |  126 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 120 insertions(+), 6 deletions(-)

Comment by Nikkhil (AceNik) - Thursday, 10 May 2007, 11:47 GMT+2
here is the version that works, you forgot to include the path to file to patch just use "p0" in this 1 & it will work
(application/octet-stream)    scroll_pad_improvement.diff (4.9 KiB) 
 firmware/target/arm/iriver/h10/button-h10.c |  126 ++++++++++++++++++++++++++--
 1 file changed, 120 insertions(+), 6 deletions(-)

Comment by Barry Wardell (barrywardell) - Wednesday, 22 August 2007, 13:42 GMT+2
There has been an improvement to the scrollpad in SVN recently. I don't think we still need this solution, do we?
Comment by Nikkhil (AceNik) - Wednesday, 22 August 2007, 21:05 GMT+2
well but even though there is an improvement in the list scan acceleration , we still need this to supplement scrolling to smoothen it, my upper end n lower end of the scrollpad still jumpy
Comment by Nikkhil (AceNik) - Wednesday, 22 August 2007, 21:26 GMT+2
kindly ignore my last comment thanks

Loading...