Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6684 - Split the party mode into two settings

Attached to Project: Rockbox
Opened by Henrik Johnson (hpj) - Thursday, 22 February 2007, 12:59 GMT+2
Last edited by Steve Bavin (pondlife) - Wednesday, 10 October 2007, 12:42 GMT+2
Task Type Patches
Category Settings
Status Unconfirmed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

I find the party mode selection being very useful in every day use as well, but I don't want all the other controls to be disabled so I added another setting called party mode selection which only affects the way songs are added to the queue instead of being played immediately.
(application/octet-stream)    party_mode_selection.diff (3.1 KiB) 
 filetree.c            |    2 +-
 lang/english.lang     |   14 ++++++++++++++
 menus/playback_menu.c |    3 ++-
 settings.h            |    1 +
 settings_list.c       |    1 +
 5 files changed, 19 insertions(+), 2 deletions(-)

This task depends upon

Comment by Henrik Johnson (hpj) - Friday, 23 February 2007, 10:50 GMT+2
Ok this new patch also fixes problem with party mode not being honored in database browsing mode and that it would corrupt the playlist if nothing was playing before you selected anything.
(application/octet-stream)    party_mode2.diff (5.4 KiB) 
 filetree.c            |    5 ++-
 lang/english.lang     |   14 ++++++++++
 menus/playback_menu.c |    3 +-
 settings.h            |    1 
 settings_list.c       |    1 
 tagtree.c             |   68 +++++++++++++++++++++++++++++++++++++++++---------
 6 files changed, 78 insertions(+), 14 deletions(-)

Comment by Henrik Johansson (mfan) - Saturday, 24 February 2007, 16:35 GMT+2
Awesome, this makes it like my winamp, where I always have enqueue as default option. Browsing my file system adds to the playlist, not changing tunes... btw, the category of this patch is a bit wrong though. ;)
Comment by Henrik Johnson (hpj) - Saturday, 24 February 2007, 20:50 GMT+2
I know the category is wrong. I didn't see it as I submitted the patch and there doesn't seem to be a way for me to change.
Comment by Zaraki San (Zsan) - Tuesday, 12 June 2007, 18:47 GMT+2
I'd like to commend you on a very nice patch. I hope to see it in cvs soon, so I can use it.
Comment by Cristiano Rodrigues (microcris) - Sunday, 31 August 2008, 12:49 GMT+2
I made some changes in your patch for I can apply it in the last svn of rockbox. I hope you don't mind..
This is a very useful patch, thanks for you work
   party_mode2.diff (5.3 KiB) 
 filetree.c             |    5 +++-
 filetree.c~            |only
 lang/english.lang      |   14 ++++++++++++
 lang/english.lang~     |only
 menus/playback_menu.c  |    3 +-
 menus/playback_menu.c~ |only
 settings.h             |    1 
 settings.h~            |only
 settings_list.c        |    1 
 settings_list.c~       |only
 tagtree.c              |   55 ++++++++++++++++++++++++++++++++++++++++++++-----
 11 files changed, 72 insertions(+), 7 deletions(-)

Loading...