Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6747 - y-margin reset in gui_list_draw

Attached to Project: Rockbox
Opened by Timo Horstschäfer (x1jmp) - Tuesday, 06 March 2007, 22:26 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Thursday, 24 April 2008, 12:42 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

When calling a menu function, the y-margin got changed, but was not reset after the function returned.

The patch fixes this behaviour and removes all unnecessary calls to lcd_setmargins from the plugins.
   y-margin-reset.patch (1.9 KiB) 
 apps/gui/list.c          |    7 +++++--
 apps/plugins/solitaire.c |    2 --
 apps/plugins/viewer.c    |    5 -----
 3 files changed, 5 insertions(+), 9 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Thursday, 24 April 2008, 12:42 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  should be all fixed (?) now
Comment by Jonathan Gordon (jdgordon) - Sunday, 11 March 2007, 09:03 GMT+2
Damn, reopening because this caused a nasty scroll bug, but this should be done..
Comment by Timo Horstschäfer (x1jmp) - Sunday, 11 March 2007, 12:40 GMT+2
Task  FS#6796  seems to have fixed the scroll bug.
Comment by Jonathan Gordon (jdgordon) - Sunday, 11 March 2007, 14:05 GMT+2
this was discussed in IRC today and it was bassically decided that storing the x/y pixel value for a scroll line was hacky and not really a good idea, so instead the list widget will be stupid and should be setting the y margin back to old margin when its exited (which isnt know :p ) so we leave it as it is....
Comment by Max Weninger (maxwen) - Tuesday, 20 March 2007, 08:34 GMT+2
ok :)

Loading...