Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6859 - Avoid crashes on the Sansa during booting

Attached to Project: Rockbox
Opened by Toni (ahellmann) - Monday, 19 March 2007, 20:44 GMT+2
Task Type Patches
Category Bootloader
Status Closed
Assigned To No-one
Player Type Sansa e200
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch should fix the occasional crashes during booting.
   bootloader.patch (1.2 KiB)
 rockbox-modified/main-pp.c |   17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

This task depends upon

Closed by  Daniel Ankers (dan_a)
Tuesday, 20 March 2007, 12:21 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed (in a slightly modified version) in r12848
Comment by Daniel Ankers (dan_a) - Tuesday, 20 March 2007, 10:43 GMT+2
Hi Toni,
Nice work! Would disabling/re-enabling the DMA perhaps be better inside lcd_init_device(), though?
Comment by Toni (ahellmann) - Tuesday, 20 March 2007, 11:29 GMT+2
Hi dan_a,
yes, I think so too. This patch was only for demonstration.

lcd_update() seems to be completely irrelevant for sansa because of auto dma-ing.
Would be interesting, what intervals are used by the dma controller.

Loading...