Rockbox

Tasklist

FS#6922 - recode filetypes.c, decrease bin by ~1400bytes on h120)

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Wednesday, 28 March 2007, 15:03 GMT
Last edited by Jonathan Gordon (jdgordon) - Wednesday, 28 March 2007, 15:13 GMT
Task Type Patches
Category Operating System/Drivers
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The annoying string buffer error came up in IRC this arvo and the idea was to move those strings to the audio buffer (its all done before the audio_init and only ever once so its safe).

This patch does that.

The patch basically starts filetypes.c from scratch to hopefully make it more readable and managable.
The only important implementation change I did was remove the ability to automatically register any rocks with the name blaa-<ext>.rock which I (and others in irc) never even knew was possible.

Now, the reason I didnt commit this is because even though it saves 1400bytes on the h120 build, it uses an extra 1100bytes RAM (compared the audio buffer size with svn on my sansa). Now, do we care about that? The code could probably use less ram, but sacrafise bin size....
oh, and ram usage will be about half of that on HW_CODEC...
last thing, can someone with HW_CODEC make sure it loads without any splashes saying too many extensions? I have a sneeking feeling it will need to be increased..... (edit: sim says its ok...)
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Thursday, 29 March 2007, 06:16 GMT
Reason for closing:  Out of Date

Loading...