Rockbox

Tasklist

FS#6948 - Fix the broken 'follow playlist' feature

Attached to Project: Rockbox
Opened by Alexander Levin (fml2) - Saturday, 31 March 2007, 12:56 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Here's a patch for the broken 'follow playlist' feature. The bug was reported on irc on Mar 30, 2007, 22:32:29 as follows:

On my H120, I press NAVI while in wps. And the folder the song is in is _not_ shown.

I've tested the patch on the sim for H120. It seems to fix the problem.
This task depends upon

Closed by  Robert Kukla (roolku)
Saturday, 31 March 2007, 22:01 GMT
Reason for closing:  Accepted
Comment by Alexander Levin (fml2) - Saturday, 31 March 2007, 21:09 GMT
Here's a better patch. The old code in the function "browser" did look right, so the error must have been somewhere else. And yes: it was in "load_screen". The value of the variable "last_screen" was changed too early.

Hopefully this will get committed.
Comment by Simon Menzel (Rincewind) - Saturday, 31 March 2007, 21:40 GMT
I tested the patch and it is working. If the DEBUGF() lines are taken out again, I think this can be commited.

Loading...