Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#6972 - reduce code size for archos player

Attached to Project: Rockbox
Opened by Dave Hooper (stripwax) - Thursday, 05 April 2007, 01:28 GMT+2
Task Type Patches
Category LCD
Status Closed
Assigned To No-one
Player Type Archos Player
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Just an idea. I'd think this would slightly reduce both static data and executable code size on archos player target. I replaced the table of bits (which is stored as chars..) in the charcell progressbar code with an array of precalculated row data, and took out many of the loops used to build the charcell since it can now be achieved using just copying (and shifting, for the progressbar itself).

Btw - I was inspired when going through the gwps diffs resulting from the new wps parser..
(application/octet-stream)    archos_progressbar.patch (5.4 KiB)
 apps/gui/gwps-common.c |  111 +++++++++++++++++--------------------------------
 1 file changed, 39 insertions(+), 72 deletions(-)

This task depends upon

Closed by  Marianne Arnold (pixelma)
Monday, 09 April 2007, 14:58 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  A different solution was committed recently

Loading...