Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7000 - Fixes scroll line behaviour for dynamic tags in new WPS code

Attached to Project: Rockbox
Opened by Dave Hooper (stripwax) - Monday, 09 April 2007, 14:35 GMT+2
Last edited by Nicolas Pennequin (nicolas_p) - Tuesday, 10 April 2007, 19:17 GMT+2
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Player Type All players
Severity Critical
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The new WPS code is broken for scrolling lines that contain dynamic info (-- I think -- certainly all 'next track' metadata tags are broken and don't scroll)

Reason is, the line is repeatedly reprinted (via puts_scroll) which has the effect of resetting the scroll x-offset, giving the impression it isn't actually scrolling at all.

New WPS code wasn't respecting the WPS_REFRESH_SCROLL flag in refresh_flags

(application/octet-stream)    wps_scroll_fix.patch (1.9 KiB) 
 apps/gui/gwps-common.c |    9 ++++++++-
 apps/gui/wps_parser.c  |    4 ++--
 2 files changed, 10 insertions(+), 3 deletions(-)

This task depends upon

Closed by  Nicolas Pennequin (nicolas_p)
Tuesday, 10 April 2007, 19:17 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed, thanks
Comment by Nicolas Pennequin (nicolas_p) - Tuesday, 10 April 2007, 18:34 GMT+2
from the reopening message:
This seems to break dynamic data that ticks dynamically during playback on scrolling fields! Oops. %s%ar%pc no longer updates , for example. So this is still critical.
Comment by Nicolas Pennequin (nicolas_p) - Tuesday, 10 April 2007, 19:16 GMT+2
The problem with %s%ar%pc was already there in the pre-tokenizer code (I just checked). This means it's a different issue and it should be reported as a separate entry.

Loading...