Rockbox

Tasklist

FS#7001 - Make rtc tags atomic, no more rtc format

Attached to Project: Rockbox
Opened by Alexander Levin (fml2) - Monday, 09 April 2007, 13:14 GMT
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This is the patch for the second part of the request  FS#6994 . It changes the RTC tags so that each tag produces a piece of text.

Before this patch: %cd m yc
After this patch: %cd %cm %cy

I.e. there are now many %cX tags. The terminating c in the RTC tags is not needed anymore.

This introduces incompatibility with the existing RTC tags. WPS's included with RB are updated in this patch.

The parser has become more elegant IMO. The code in gwps-common.c has become uglier at one place since the structure cur_time is filled not directly at the place where it's used.
This task depends upon

Closed by  Nicolas Pennequin (nicolas_p)
Tuesday, 10 April 2007, 13:37 GMT
Reason for closing:  Accepted
Additional comments about closing:  Committed, thanks
Comment by Nicolas Pennequin (nicolas_p) - Monday, 09 April 2007, 14:14 GMT
Does this help binsize ?
I like the idea and the patch, but whether to commit it or not isn't really my decision to make. Maybe you should try raising the issue on the IRC channel to see how well it's received.
Comment by Alexander Levin (fml2) - Monday, 09 April 2007, 18:53 GMT
As some code has been deleted I think that the bin size is reduced by this patch.

Loading...