This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#7001 - Make rtc tags atomic, no more rtc format
|
DetailsThis is the patch for the second part of the request
Before this patch: %cd m yc After this patch: %cd %cm %cy I.e. there are now many %cX tags. The terminating c in the RTC tags is not needed anymore. This introduces incompatibility with the existing RTC tags. WPS's included with RB are updated in this patch. The parser has become more elegant IMO. The code in gwps-common.c has become uglier at one place since the structure cur_time is filled not directly at the place where it's used. 
wps_rtc_tokens.patch
(15.7 KiB)
apps/gui/gwps-common.c | 82 ++++++++++++++++++++++++----------------------- apps/gui/gwps.h | 1 apps/gui/wps_debug.c | 40 ++++++++++++++++++---- apps/gui/wps_parser.c | 78 ++++++++++---------------------------------- wps/boxes.220x176x16.wps | 2 - 5 files changed, 95 insertions(+), 108 deletions(-) |
This task depends upon
Closed by Nicolas Pennequin (nicolas_p)
Tuesday, 10 April 2007, 15:37 GMT+2
Reason for closing: Accepted
Additional comments about closing: Committed, thanks
Tuesday, 10 April 2007, 15:37 GMT+2
Reason for closing: Accepted
Additional comments about closing: Committed, thanks
I like the idea and the patch, but whether to commit it or not isn't really my decision to make. Maybe you should try raising the issue on the IRC channel to see how well it's received.