Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7093 - Latest WPS parser change lets long strings crash rockbox - fix

Attached to Project: Rockbox
Opened by Dave Hooper (stripwax) - Monday, 30 April 2007, 23:38 GMT+2
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Some buffer overruns in latest wps_parser.c change. Patch attached.
(application/octet-stream)    wps_parser.patch (1.8 KiB) 
 apps/gui/wps_parser.c |   12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

This task depends upon

Closed by  Peter D'Hoye (petur)
Wednesday, 02 May 2007, 01:36 GMT+2
Reason for closing:  Accepted
Comment by Dave Hooper (stripwax) - Tuesday, 01 May 2007, 00:25 GMT+2
improved patch. Previously we'd stop reading literal strings when the string buffer was full, regardless of whether the new string literal is a duplicate or not. Now we output a text token if the newly read string is a dupe even when the string buffer is already full. This hopefully gives the most benefit
(application/octet-stream)    wps_parser.patch (3.9 KiB) 
 apps/gui/wps_parser.c |   49 +++++++++++++++++++++++++++----------------------
 1 file changed, 27 insertions(+), 22 deletions(-)

Comment by Dave Hooper (stripwax) - Wednesday, 02 May 2007, 01:07 GMT+2
Removed extraneous printf. Reduced length of long lines.
(application/octet-stream)    wps_parser.patch (3.7 KiB) 
 apps/gui/wps_parser.c |   51 ++++++++++++++++++++++++++++----------------------
 1 file changed, 29 insertions(+), 22 deletions(-)

Loading...