Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7105 - Music Led

Attached to Project: Rockbox
Opened by Dagni McPhee (donutman25) - Friday, 04 May 2007, 08:04 GMT+1
Last edited by Jonathan Gordon (jdgordon) - Monday, 06 August 2007, 04:29 GMT+1
Task Type Patches
Category Music playback
Status Closed
Assigned To No-one
Player Type Sansa e200
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

First attempt to make the scrollwheel led beat to the music. Only tested it with the ipod_sansa theme. Please tell me if you experience bugs. Feel free to improve this because i have no programming knowledge.
   music_led.patch (0.4 KiB) 
 peakmeter-e.c |    6 ++++++
 1 file changed, 6 insertions(+)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Monday, 06 August 2007, 04:29 GMT+1
Reason for closing:  Rejected
Comment by Dagni McPhee (donutman25) - Friday, 04 May 2007, 08:17 GMT+1
It does not work with themes that do not have the peak meter enabled. I'm gonna work more on this tomorrow. Its late and i have school in the morning.
Comment by Dagni McPhee (donutman25) - Saturday, 05 May 2007, 04:12 GMT+1
Small change to make the scrollwheel more sensitive to the changes in dbfs. I think :|
   music_led.patch (0.4 KiB) 
 apps/recorder/peakmeter-e.c |    7 +++++++
 1 file changed, 7 insertions(+)

Comment by Michael Hahn (disorganizer) - Wednesday, 13 June 2007, 23:44 GMT+1
it would maybe be a good idea to check the scrollwheel light setting to enable or disable this patch via settings. if scrollwheel light is set to off then the patch should imho be disabled.
or maybe even only enable it when the scrollwheel is set to permanent on.

that way i can use the peakmeter in builds with included music-led patch :-)
Comment by Aarto Matti (Aarto) - Wednesday, 13 June 2007, 23:57 GMT+1
I'd like to have a separate settings for this feature, it shouldn't depend on scrollwheel settings.
Comment by Jack Suter (chrisjs169) - Thursday, 14 June 2007, 23:43 GMT+1
Since most WPSs look bad with the peakmeter in them, shouldn't the complaint be having a setting to turn it on without %pm in the WPS file, not the other way around? IMO it's already 'off' by default (unless you're using the default rockbox theme)
Comment by Michael Hahn (disorganizer) - Friday, 15 June 2007, 12:34 GMT+1
good point. maybe it could be a % directive in the WPS file to trigger the musicled feature.
Comment by Aarto Matti (Aarto) - Monday, 18 June 2007, 23:36 GMT+1
the better idea is to realize it as a plugin, thus it won't be necessary to worry about %pm tag or adjusting the scrollwheel light
to use the feature when you need it only
Comment by Michael Hahn (disorganizer) - Wednesday, 20 June 2007, 11:32 GMT+1
i think its own % tag for the wps would be the better idea because you can easily turn it off when switching the wps (for example no blinking in car-wps, but blinking in mobile-wps).

Loading...