Rockbox

Tasklist

FS#7164 - FS#6780: Improve WPS volume conditional

Attached to Project: Rockbox
Opened by Nicolas Pennequin (nicolas_p) - Sunday, 13 May 2007, 16:12 GMT
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This patch implements the feature requested in  FS#6780  and discussed in http://forums.rockbox.org/index.php?topic=10418.0.
the volume enum is now %?pv<Mute|...|...|0 dB|Above 0 dB> for targets that can go above 0 dB, and %?pv<Mute|...|...|0 dB> for targets that can't.
This task depends upon

Closed by  Nicolas Pennequin (nicolas_p)
Monday, 14 May 2007, 14:37 GMT
Reason for closing:  Accepted
Additional comments about closing:  Committed
Comment by Nicolas Pennequin (nicolas_p) - Monday, 14 May 2007, 09:43 GMT
Having two different cases is a bad idea because it hurts WPS portability. The volume enum is now %?pv<Mute|...|...|0 dB|Above 0 dB> for all targets. On targets that can't go above 0 dB, the last case will never be used.

Loading...