Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7164 - FS#6780: Improve WPS volume conditional

Attached to Project: Rockbox
Opened by Nicolas Pennequin (nicolas_p) - Sunday, 13 May 2007, 18:12 GMT+2
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch implements the feature requested in  FS#6780  and discussed in http://forums.rockbox.org/index.php?topic=10418.0.
the volume enum is now %?pv<Mute|...|...|0 dB|Above 0 dB> for targets that can go above 0 dB, and %?pv<Mute|...|...|0 dB> for targets that can't.
   wps_volume.patch (1.4 KiB) 
 apps/gui/gwps-common.c |   25 +++++++++++++++++++++----
 1 file changed, 21 insertions(+), 4 deletions(-)

This task depends upon

Closed by  Nicolas Pennequin (nicolas_p)
Monday, 14 May 2007, 16:37 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed
Comment by Nicolas Pennequin (nicolas_p) - Monday, 14 May 2007, 11:43 GMT+2
Having two different cases is a bad idea because it hurts WPS portability. The volume enum is now %?pv<Mute|...|...|0 dB|Above 0 dB> for all targets. On targets that can't go above 0 dB, the last case will never be used.
   wps_volume.patch (1.3 KiB) 
 apps/gui/gwps-common.c |   23 +++++++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

Loading...