Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7177 - Adds a setting to display special tags last in the database

Attached to Project: Rockbox
Opened by Simon Génier (sgenier) - Wednesday, 16 May 2007, 16:35 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Saturday, 04 August 2007, 16:45 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This adds a setting that change the position of the <Untagged> and <All tracks> tags in the database, so they are display after regular entries. This is especially good when you have only one entry, since it save the effort of pressing "down". Also, since the main goal of the database is to have tagged tracks, I guess <Untagged> is not used as much as regular tags.
I just want to warn you of something that can be unexpected: Since <Untagged> tags are sorted at commit time, the tagcache must be recommited after changing the setting. I guess I could have used a callback to do it automatically, but because a recommit is quite long, I chose to leave it to the user.
   special_tags_last.patch (4.7 KiB) 
 apps/lang/english.lang     |   14 ++++++++++++++
 apps/settings.h            |    1 +
 apps/menus/settings_menu.c |    3 ++-
 apps/settings_list.c       |    2 ++
 apps/tagcache.c            |    4 ++--
 apps/tagtree.c             |   38 +++++++++++++++++++++++++++++---------
 6 files changed, 50 insertions(+), 12 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Saturday, 04 August 2007, 16:45 GMT+2
Reason for closing:  Rejected
Comment by Simon Génier (sgenier) - Wednesday, 23 May 2007, 04:34 GMT+2
I changed the patch so it applies cleanly on svn version 13475.
   special_tags_last_13475.patch (4.7 KiB) 
 apps/lang/english.lang     |   15 ++++++++++++++-
 apps/settings.h            |    1 +
 apps/menus/settings_menu.c |    3 ++-
 apps/settings_list.c       |    2 ++
 apps/tagcache.c            |    4 ++--
 apps/tagtree.c             |   38 +++++++++++++++++++++++++++++---------
 6 files changed, 50 insertions(+), 13 deletions(-)

Loading...