Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7215 - Make .lng and .voice files target specific

Attached to Project: Rockbox
Opened by Nils Wallménius (nls) - Saturday, 26 May 2007, 19:05 GMT+2
Last edited by Nils Wallménius (nls) - Thursday, 02 August 2007, 13:58 GMT+2
Task Type Patches
Category Language
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch makes the .lng files and voice files target specific. This is needed before we can start to use some of the new features of lang v2 some of which the big cleanup patch depends.
I'm no wizard when it comes to shell scripts and perl so I am pretty sure that there are better ways to do some things and would be happy to get some coments.
It works on my player (h300) and appears to work ok in the sim but there's a bug in the sim that crashes it with voice files on amd64 (this bug was there before).
   target_spec.diff (10.2 KiB) 
 tools/configure   |   10 +++++-----
 tools/buildzip.pl |   10 ++++++++--
 tools/genvoice.sh |   11 ++++++-----
 tools/voicefont.c |   25 +++++++++++++++----------
 tools/genlang     |   13 ++++++++++---
 apps/language.c   |    7 ++++---
 apps/language.h   |    2 +-
 apps/talk.c       |    6 ++++++
 8 files changed, 55 insertions(+), 29 deletions(-)

This task depends upon

View Dependency Graph

This task blocks these from closing
 FS#6574 - Lang v2 cleanup 
Closed by  Nils Wallménius (nls)
Thursday, 02 August 2007, 13:58 GMT+2
Reason for closing:  Invalid
Additional comments about closing:  This patch has been merged with  FS#6574 
Comment by Daniel Stenberg (bagder) - Sunday, 27 May 2007, 10:35 GMT+2
I've read the patch and I think it looks fine!
Comment by Steve Bavin (pondlife) - Wednesday, 27 June 2007, 11:08 GMT+2
A minor point - shouldn't the example command line given be updated too?

Loading...