Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7258 - new list selection code hopefully fix all existing bugs

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Monday, 04 June 2007, 11:33 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Tuesday, 05 June 2007, 04:57 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Putting this up to get some feedback before commiting, seen as every time I think its working, someone goes out of their way to proove me wrong :D

This version is simple and has plenty of room for optimizing, but want to make sure it works in all cases before cleaning it up a bit.
   list.patch (8.2 KiB) 
 apps/gui/list.c |  181 +++++++++++++++++++++++---------------------------------
 1 file changed, 76 insertions(+), 105 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Tuesday, 05 June 2007, 04:57 GMT+2
Reason for closing:  Accepted
Comment by Steve Bavin (pondlife) - Monday, 04 June 2007, 11:50 GMT+2
SVN + this patch doesn't allow the cursor bar to go to the top or bottom of the screen before scrolling. Also the screen is entirely refreshed/scrolled when not needed.

Example, with 18 files in a folder, on H300 sim:
- BEFORE.JPG shows track 06 selected, with track 04 at the top and 14 at the bottom.
- I then press DOWN once to select track 07.
- AFTER.JPG shows track 07 selected, with track 01 at the top and 11 at the bottom. It should have just moved the cursor bar down and not scrolled at all.


   before.jpg (22.4 KiB)
   after.jpg (22.5 KiB)
Comment by Jonathan Gordon (jdgordon) - Monday, 04 June 2007, 13:51 GMT+2
well, after doing a diff and almost reverting the whole acceleration code, I've fixed your bug.
   list.patch (8.3 KiB) 
 apps/gui/list.c |  184 ++++++++++++++++++++++++--------------------------------
 1 file changed, 79 insertions(+), 105 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Monday, 04 June 2007, 14:32 GMT+2
minor update
   list.patch (8.8 KiB) 
 apps/gui/list.c |  189 ++++++++++++++++++++++++--------------------------------
 1 file changed, 83 insertions(+), 106 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Monday, 04 June 2007, 16:43 GMT+2
fixed the bug where you could fall off the end.
tries to make sure the first line of a multi-line item isnt the last line on the screen
   list.patch (9 KiB) 
 apps/gui/list.c |  197 +++++++++++++++++++++++++-------------------------------
 1 file changed, 91 insertions(+), 106 deletions(-)

Comment by Nicolas Pennequin (nicolas_p) - Monday, 04 June 2007, 23:13 GMT+2
Latest patch seems to work fine for me... I haven't seen anything strange :)

Loading...