Rockbox

Tasklist

FS#7258 - new list selection code hopefully fix all existing bugs

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Monday, 04 June 2007, 09:33 GMT
Last edited by Jonathan Gordon (jdgordon) - Tuesday, 05 June 2007, 02:57 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Putting this up to get some feedback before commiting, seen as every time I think its working, someone goes out of their way to proove me wrong :D

This version is simple and has plenty of room for optimizing, but want to make sure it works in all cases before cleaning it up a bit.
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Tuesday, 05 June 2007, 02:57 GMT
Reason for closing:  Accepted
Comment by Steve Bavin (pondlife) - Monday, 04 June 2007, 09:50 GMT
SVN + this patch doesn't allow the cursor bar to go to the top or bottom of the screen before scrolling. Also the screen is entirely refreshed/scrolled when not needed.

Example, with 18 files in a folder, on H300 sim:
- BEFORE.JPG shows track 06 selected, with track 04 at the top and 14 at the bottom.
- I then press DOWN once to select track 07.
- AFTER.JPG shows track 07 selected, with track 01 at the top and 11 at the bottom. It should have just moved the cursor bar down and not scrolled at all.


Comment by Jonathan Gordon (jdgordon) - Monday, 04 June 2007, 11:51 GMT
well, after doing a diff and almost reverting the whole acceleration code, I've fixed your bug.
Comment by Jonathan Gordon (jdgordon) - Monday, 04 June 2007, 12:32 GMT
minor update
Comment by Jonathan Gordon (jdgordon) - Monday, 04 June 2007, 14:43 GMT
fixed the bug where you could fall off the end.
tries to make sure the first line of a multi-line item isnt the last line on the screen
Comment by Nicolas Pennequin (nicolas_p) - Monday, 04 June 2007, 21:13 GMT
Latest patch seems to work fine for me... I haven't seen anything strange :)

Loading...