Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7289 - Allow upto 512 images to be used in WPS

Attached to Project: Rockbox
Opened by Darren Turland (kahuna_999) - Monday, 11 June 2007, 14:28 GMT+2
Last edited by Dave Chapman (linuxstb) - Monday, 24 March 2008, 01:09 GMT+2
Task Type Patches
Category Themes
Status Closed
Assigned To Nicolas Pennequin (nicolas_p)
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch adds the ability to display part of a loaded bitmap in the wps.
It still only allows the maximum 52 bitmaps to be loaded but adds a new tag %xp to display upto 512 bitmap parts onto the screen. This partners the existing %xd tag.
Similar to patch  FS#2791  (appears defunct as not updated for over 1 year), but lifts the limit of available image displays to 512.

There are two variations on the command. The first will use the x,y coordinates from the corresponding %xl tag, the second allows you to specify them.

%xp<bitmap load id>|srcx|srcy|w|h|
%xp<bitmap load id>|srcx|srcy|w|h|x|y|

The %xp tag can be used in conditions.

I hope the artists out there can make use of the additional display capabilities and come up with some fancy graphical wps’s

Initial version synced to svn13614
   wps_display_512_bitmaps_svn13614.patch (10.1 KiB) 
 ./apps/gui/gwps-common.c |   73 ++++++++++++++++++++++++++++-----------
 ./apps/gui/gwps.h        |   18 +++++++++
 ./apps/gui/wps_parser.c  |   86 +++++++++++++++++++++++++++++++++++++++++++++--
 3 files changed, 154 insertions(+), 23 deletions(-)

This task depends upon

Closed by  Dave Chapman (linuxstb)
Monday, 24 March 2008, 01:09 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  Partial bitmap display has now been implemented in SVN with "bitmap strips".
Comment by Darren Turland (kahuna_999) - Wednesday, 13 June 2007, 13:59 GMT+2
Decided not to overload the %xp tag as it caused too many issues in the conditional tags..

Now have the following two new tags
%xp<bitmap load id>|srcx|srcy|w|h|
%xx<bitmap load id>|srcx|srcy|w|h|x|y|
   wps_display_512_bitmaps_svn13614.patch (12 KiB) 
 ./apps/gui/gwps-common.c |   77 ++++++++++++++++++--------
 ./apps/gui/gwps.h        |   18 ++++++
 ./apps/gui/wps_parser.c  |  139 ++++++++++++++++++++++++++++++++++++++++++++++-
 3 files changed, 211 insertions(+), 23 deletions(-)

Comment by Darren Turland (kahuna_999) - Wednesday, 20 June 2007, 14:39 GMT+2
sync'd (see filename) and updated following forum comments.

Back to a single overloaded tag, but with new parm seperators...

%xp<bitmap load id>:srcx:srcy:w:h
%xp<bitmap load id>:srcx:srcy:w:h:x:y

This makes its use in conditionals _much_ easier to use and read.
   wps_display_512_bitmaps_svn13664.patch (10.3 KiB) 
 ./apps/gui/gwps-common.c |   77 ++++++++++++++++++++++++++++++-----------
 ./apps/gui/gwps.h        |   18 +++++++++
 ./apps/gui/wps_parser.c  |   87 +++++++++++++++++++++++++++++++++++++++++++++--
 3 files changed, 159 insertions(+), 23 deletions(-)

Comment by Rani Hod (RaeNye) - Saturday, 23 June 2007, 01:44 GMT+2
I think this patch is a good idea.
However, I don't see why you had to change the separators from the de facto WPS standard pipe (|).
Comment by Peter D'Hoye (petur) - Sunday, 24 June 2007, 15:42 GMT+2
RaeNye, I guess he explained it in the comment just above yours :p
Comment by Darren Turland (kahuna_999) - Wednesday, 12 September 2007, 10:15 GMT+2
Sync'd to r14667
   wps_display_512_bitmaps_svn14667.patch (10.3 KiB) 
 ./apps/gui/gwps-common.c |   77 ++++++++++++++++++++++++++++++-----------
 ./apps/gui/gwps.h        |   18 +++++++++
 ./apps/gui/wps_parser.c  |   87 +++++++++++++++++++++++++++++++++++++++++++++--
 3 files changed, 159 insertions(+), 23 deletions(-)

Loading...