Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7310 - Convert vu_meter to use the new menu api, with problems :-(

Attached to Project: Rockbox
Opened by Nils Wallménius (nls) - Thursday, 14 June 2007, 20:54 GMT+2
Last edited by Nils Wallménius (nls) - Thursday, 14 June 2007, 21:46 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch replaces the custom menu in the vu_meter plugin with one using the new menu api.

This fixes two issues:
* up/down buttons were reversed
* fg/bg colours were inversed instead of reversed

It also makes the menu more visually appealing with icons and using the user font.

It all works beautifully on my player (H320) but when I change the meter type option in the simulator I get a segfault in settings.c line 424

This simulator is built with gcc 4.1.2 for AMD64 on ubuntu 7.04

It would probably be helpful if someone could try a 32 bit sim...
   vu_meter_menu.diff (12.5 KiB) 
 apps/plugins/vu_meter.c |  210 +++++++++++++++++-------------------------------
 apps/plugin.c           |    1 
 apps/plugin.h           |    7 +
 3 files changed, 82 insertions(+), 136 deletions(-)

This task depends upon

Closed by  Nils Wallménius (nls)
Thursday, 14 June 2007, 21:46 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  close this as it's not a problem with the patch...
Comment by Nils Wallménius (nls) - Thursday, 14 June 2007, 21:26 GMT+2
hmm, I get the same segfault if I try to change the settings in the clock plugin...

Loading...