Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7362 - Support for GROUPING tag

Attached to Project: Rockbox
Opened by Dieter (dip) - Wednesday, 27 June 2007, 01:13 GMT+2
Last edited by Dan Everton (safetydan) - Wednesday, 08 August 2007, 12:30 GMT+2
Task Type Patches
Category ID3 / meta data
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch adds support for the GROUPING tag which is usually used for grouping titles of multi part works (e.g. classical works like symphonies or sonatas). It supports id3v2.2 (TT1), id3v2.3 and id3v2.4 (TIT1), mp4 (cgrp) and vorbis comments (GROUPING as used by MusicBrainz, CONTENTGROUP as used by MP3Tag and CONTENT GROUP as used by foobar2000). In WPS you can use %iG and %IG. As tagnavi.conf tags "grouping" and "contentgroup" are supported but not "content group" due to the space in the middle.

In addition, when building the database and a track doesn't have a grouping tag, it copies the value from the title tag. This should make browsing through classcical works in the database a bit nicer since you will find all your music, not only titles having the grouping tag explicitely set (similar to the recent albumartist improvement). You need to rebuild your database to actually see any change.
   grouping.patch (14.4 KiB) 
 apps/screens.c                  |   28 ++++++++++++++++------------
 apps/metadata/mp4.c             |    6 ++++++
 apps/metadata/metadata_common.c |   12 ++++++++++++
 apps/lang/deutsch.lang          |   14 ++++++++++++++
 apps/lang/english.lang          |   14 ++++++++++++++
 apps/gui/gwps-common.c          |    3 +++
 apps/gui/wps_debug.c            |    5 +++++
 apps/gui/gwps.h                 |    1 +
 apps/gui/wps_parser.c           |    2 ++
 apps/tagcache.c                 |   28 ++++++++++++++++++++++++----
 apps/tagcache.h                 |    6 +++---
 apps/tagtree.c                  |    2 ++
 firmware/export/id3.h           |    1 +
 firmware/id3.c                  |    6 +++++-
 14 files changed, 108 insertions(+), 20 deletions(-)

This task depends upon

Closed by  Dan Everton (safetydan)
Wednesday, 08 August 2007, 12:30 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Patch committed. Thanks.
Comment by Dieter (dip) - Wednesday, 27 June 2007, 01:25 GMT+2
I didn't mean WPS-tags when mentioning "grouping" and "contentgroup" but the tags for the tagnavi.conf file. (Isn't there a way to edit my own post?)
Comment by Dieter (dip) - Tuesday, 24 July 2007, 00:00 GMT+2
LinusN already stated in this thread http://forums.rockbox.org/index.php?topic=11173.0 that this patch may be committed. Could some developer please commit it that Rockbox support for classical music is improved?
Thanks a lot.
Comment by Dieter (dip) - Tuesday, 31 July 2007, 22:34 GMT+2
synced
   grouping_20070731patch (14.4 KiB)
Comment by Dan Everton (safetydan) - Tuesday, 07 August 2007, 13:23 GMT+2
Synced. Needs testing again though and I don't really have the setup to do that.
   grouping_20070807_r14229.patch (14.7 KiB) 
 apps/screens.c                  |   30 +++++++++++++++++-------------
 apps/metadata/mp4.c             |    6 ++++++
 apps/metadata/metadata_common.c |   12 ++++++++++++
 apps/lang/deutsch.lang          |   14 ++++++++++++++
 apps/lang/english.lang          |   14 ++++++++++++++
 apps/gui/gwps-common.c          |    3 +++
 apps/gui/wps_debug.c            |    5 +++++
 apps/gui/gwps.h                 |    1 +
 apps/gui/wps_parser.c           |    2 ++
 apps/tagcache.c                 |   28 ++++++++++++++++++++++++----
 apps/tagcache.h                 |    6 +++---
 apps/tagtree.c                  |    2 ++
 firmware/export/id3.h           |    1 +
 firmware/id3.c                  |    6 +++++-
 14 files changed, 109 insertions(+), 21 deletions(-)

Comment by Dieter (dip) - Tuesday, 07 August 2007, 22:51 GMT+2
I tested it with the current svn (r14233M-070807) and it works great.
Comment by Dan Everton (safetydan) - Wednesday, 08 August 2007, 12:06 GMT+2
What's your real name for the credits? Or are you already in the credits file?
Comment by Dieter (dip) - Wednesday, 08 August 2007, 12:16 GMT+2
My real name is Dieter Pellkofer. I have no idea if I am already in the credits file. The only patch I created and which was committed so long was the album artist and comment patch (which was based on a patch from Robert Kukla). Should I amend my profile to include my complete name, if yes, how can I do that?

Loading...