Rockbox

Tasklist

FS#7422 - Autoscore not displayed properly in WPS

Attached to Project: Rockbox
Opened by Eddy (bascule) - Tuesday, 10 July 2007, 19:00 GMT
Last edited by Steve Bavin (pondlife) - Wednesday, 11 July 2007, 08:03 GMT
Task Type Bugs
Category Themes
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Gigabeat F20 r13755
Autoscores displayed in the WPS (%ra tag) are missing the last character, so I get:

Autoscore Display
100 10
99 9
84 8

The code where I think it is displayed from in /trunk/apps/gui/gwps-common.c looks OK to my untutored eyes...

case WPS_TOKEN_DATABASE_AUTOSCORE:
if (intval)
*intval = id3->score + 1;

snprintf(buf, buf_size, "%d", id3->score);
return buf;

Topic http://forums.rockbox.org/index.php?topic=11470.0 refers
This task depends upon

Closed by  Steve Bavin (pondlife)
Wednesday, 11 July 2007, 08:03 GMT
Reason for closing:  Not a Bug
Additional comments about closing:  Having asked around, this is intentional. Autoscores are stored in the file in the range 0-100 to give an extra decimal place, but they are actually ranged 0-10 (like ratings).
Comment by Steve Bavin (pondlife) - Wednesday, 11 July 2007, 07:53 GMT
The problem is not in the WPS code, it's in the reading of the autoscore tag. tagcache.c contains the line:

id3->score = get_tag_numeric(entry, tag_virt_autoscore) / 10;

I'd guess that the idea was to bring scores and ratings (which are in range 0-10) into the same range, but it seems wrong to me. I'll ask on IRC and see if this behaviour is desirable. (I don't use autoscore myself.)
Comment by Steve Bavin (pondlife) - Wednesday, 11 July 2007, 07:56 GMT
I also noticed that tagtree.c has the following line:
id3->score = tagcache_get_numeric(&tcs, tag_virt_autoscore) / 10;

Loading...