This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#7422 - Autoscore not displayed properly in WPS
Attached to Project:
Rockbox
Opened by Eddy (bascule) - Tuesday, 10 July 2007, 21:00 GMT+2
Last edited by Steve Bavin (pondlife) - Wednesday, 11 July 2007, 10:03 GMT+2
Opened by Eddy (bascule) - Tuesday, 10 July 2007, 21:00 GMT+2
Last edited by Steve Bavin (pondlife) - Wednesday, 11 July 2007, 10:03 GMT+2
|
DetailsGigabeat F20 r13755
Autoscores displayed in the WPS (%ra tag) are missing the last character, so I get: Autoscore Display 100 10 99 9 84 8 The code where I think it is displayed from in /trunk/apps/gui/gwps-common.c looks OK to my untutored eyes... case WPS_TOKEN_DATABASE_AUTOSCORE: if (intval) *intval = id3->score + 1; snprintf(buf, buf_size, "%d", id3->score); return buf; Topic http://forums.rockbox.org/index.php?topic=11470.0 refers |
This task depends upon
Closed by Steve Bavin (pondlife)
Wednesday, 11 July 2007, 10:03 GMT+2
Reason for closing: Not a Bug
Additional comments about closing: Having asked around, this is intentional. Autoscores are stored in the file in the range 0-100 to give an extra decimal place, but they are actually ranged 0-10 (like ratings).
Wednesday, 11 July 2007, 10:03 GMT+2
Reason for closing: Not a Bug
Additional comments about closing: Having asked around, this is intentional. Autoscores are stored in the file in the range 0-100 to give an extra decimal place, but they are actually ranged 0-10 (like ratings).
id3->score = get_tag_numeric(entry, tag_virt_autoscore) / 10;
I'd guess that the idea was to bring scores and ratings (which are in range 0-10) into the same range, but it seems wrong to me. I'll ask on IRC and see if this behaviour is desirable. (I don't use autoscore myself.)
id3->score = tagcache_get_numeric(&tcs, tag_virt_autoscore) / 10;