Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7528 - Superdom should yield during AI calculations

Attached to Project: Rockbox
Opened by Nikkhil (AceNik) - Friday, 03 August 2007, 16:59 GMT+2
Last edited by Jonas Häggqvist (rasher) - Thursday, 11 December 2008, 03:02 GMT+2
Task Type Bugs
Category Plugins
Status Closed
Assigned To No-one
Player Type iriver H10
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Hey guys the new superdom plugin is very nice, but , when i try playing the game with increasing the computers farms & factories to above normal level like suppose 2,2 & also have music playback in the background the H10[20GB] seems to have lot of hang ups, i dont know if this is true for other players if yes, please feel free to add in your comments

btw this is regarding rockbox build no. 14156

[admin edit: Title updated to better reflect the problem]
This task depends upon

Closed by  Jonas Häggqvist (rasher)
Thursday, 11 December 2008, 03:02 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Patch that should fix this issue committed in r19389.
Comment by Jonas Häggqvist (rasher) - Friday, 03 August 2007, 17:18 GMT+2
  • Field changed: Summary (Frequent Hang-Ups During Superdom → Superdom should yield during AI calculations)
  • Field changed: Details
Looking at the code, Superdom doesn't yield a single time. This should probably be fixed and should hopefully let music playback continue.
Comment by Johnathon Mihalop (Soul-Slayer) - Friday, 03 August 2007, 18:59 GMT+2
Patch that adds yielding. I can't be 100% sure it works as my H10 is a 6GB, so it's screen is too small to test. I tried it on my Gigabeat though and hasn't caused any freezes.
   superdomyield.diff (6.6 KiB) 
 apps/plugins/superdom.c |   42 +++++++++++++++++++++++++-----------------
 1 file changed, 25 insertions(+), 17 deletions(-)

Comment by Will Robertson (aliask) - Saturday, 04 August 2007, 15:08 GMT+2
I haven't got a DAP to test this patch on, but it takes Johnathon's idea and tweaks it a bit. If this fixes everything up then I'll commit, but I have no way to know until I can get some feedback.
   superyield.patch (7.2 KiB) 
 apps/plugins/superdom.c |   45 ++++++++++++++++++++++++++++-----------------
 1 file changed, 28 insertions(+), 17 deletions(-)

Comment by Will Robertson (aliask) - Tuesday, 14 August 2007, 12:20 GMT+2
Hopefully a more accurate patch. I do need feedback on these though, as I have no way of telling if these work or not.
   superdom_yieldmore.patch (1.8 KiB) 
 apps/plugins/superdom.c |    8 ++++++++
 1 file changed, 8 insertions(+)

Comment by Jonathan Gordon (jdgordon) - Friday, 28 November 2008, 04:17 GMT+2
Will, can this be commited?
Comment by Will Robertson (aliask) - Friday, 28 November 2008, 04:40 GMT+2
Let me test it on my gigabeat, with and without patches and I'll see how it goes.
Comment by Will Robertson (aliask) - Friday, 28 November 2008, 05:55 GMT+2
Played two whole games with music running in the background, no noticeable freezes without patch - perhaps someone with a lower powered target than the Gigabeat S should test this.
Comment by Daniel Stenberg (bagder) - Monday, 01 December 2008, 14:28 GMT+2
Well, I don't think the yields will introduce many problems but at least fix some so I think this should be committed rather than to wait for testers...
Comment by Andrew Mahone (Unhelpful) - Thursday, 11 December 2008, 02:57 GMT+2
Commit this. I agree with Daniel, we can't be sure this entirely fixes the problem, but it will likely help and is harmless.

Loading...